Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation of the score #2

Closed
3 tasks done
aykborstelmann opened this issue Sep 16, 2019 · 2 comments
Closed
3 tasks done

Calculation of the score #2

aykborstelmann opened this issue Sep 16, 2019 · 2 comments
Labels
feature A new feature to add good first issue Good for newcomers
Projects
BJS API
Milestone
Basic Functionality

Comments

@aykborstelmann
Copy link
Member

aykborstelmann commented Sep 16, 2019 •
edited
Loading

The score should be calculated centralized in the API.
I recommend this to be accessible at /api/v1/students/<student>/score.

The following steps might be helpfull

  • Finding the formula for the right calculation of the BJS-Score
  • Implementing the calculation of the formula
  • Implementing a RestController for this purpose

This might help.
@aykborstelmann aykborstelmann added the feature A new feature to add label Sep 16, 2019
@aykborstelmann aykborstelmann added this to To do in BJS API via automation Sep 16, 2019
@aykborstelmann aykborstelmann added this to the Basic Functionality milestone Sep 16, 2019
@aykborstelmann aykborstelmann added the good first issue Good for newcomers label Sep 16, 2019
@aykborstelmann aykborstelmann moved this from To do to In progress in BJS API Sep 17, 2019
@aykborstelmann aykborstelmann moved this from In progress to To do in BJS API Sep 17, 2019
@ghost

This comment has been minimized.

Sign in to view
@aykborstelmann aykborstelmann assigned ghost Sep 28, 2019
@aykborstelmann aykborstelmann mentioned this issue Sep 28, 2019
Merged
@aykborstelmann aykborstelmann moved this from To do to In progress in BJS API Sep 28, 2019
BJS API automation moved this from In progress to Done Nov 24, 2019
@aykborstelmann
Copy link
Member Author

😫 We forgot:

The total score gets sums up the 3 best scores.

@aykborstelmann aykborstelmann moved this from Done to In progress in BJS API Nov 24, 2019
@ghost ghost mentioned this issue Nov 26, 2019
Merged
aykborstelmann added a commit that referenced this issue Nov 26, 2019
@aykborstelmann
Refactoring top-3 change (#2)
344478b
aykborstelmann pushed a commit that referenced this issue Nov 26, 2019
@liamskydamien @aykborstelmann
Change the function of calculation to sum up the best 3 scores. (#10)
b66fb80 
* Change the function of calculation, to sum up, the best 3 scores.
* Refactoring top-3 change (#2)
@aykborstelmann aykborstelmann moved this from In progress to Done in BJS API Nov 27, 2019
aykborstelmann pushed a commit that referenced this issue Dec 7, 2019
@liamskydamien
Change the function of calculation to sum up the best 3 scores. (#10)
2bc349d 
* Change the function of calculation, to sum up, the best 3 scores.
* Refactoring top-3 change (#2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new feature to add good first issue Good for newcomers
Projects
BJS API
Done
Milestone
Basic Functionality
Development

No branches or pull requests
1 participant
@aykborstelmann