Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 Calculation of the score #4

Merged
merged 5 commits into from
Nov 24, 2019
Merged

#2 Calculation of the score #4

merged 5 commits into from
Nov 24, 2019

Conversation

aykborstelmann
Copy link
Member

#2 I've already added the frame for the implementation so that you have a point to start.

@aykborstelmann aykborstelmann added the feature A new feature to add label Sep 28, 2019
@aykborstelmann aykborstelmann added this to the Basic Functionality milestone Sep 28, 2019
aykborstelmann
aykborstelmann commented Sep 28, 2019
View reviewed changes
Copy link
Member Author

@aykborstelmann aykborstelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are only a few suggestions on your code.
If you've got time, you can look at them.

api/src/main/java/com/bjs/bjsapi/controllers/StudentScoreController.java Outdated Show resolved Hide resolved
api/src/main/java/com/bjs/bjsapi/database/model/enums/DisciplineType.java Show resolved Hide resolved
api/src/main/java/com/bjs/bjsapi/controllers/StudentScoreController.java Outdated Show resolved Hide resolved
aykborstelmann
aykborstelmann commented Nov 19, 2019
View reviewed changes
Copy link
Member Author

@aykborstelmann aykborstelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you already have implemented the logic for summing all sport result scores together (see StudentController 38:54). I think all those greatly implemented.

If you realise those tiny suggestions, I think this will ready to merge

api/src/main/java/com/bjs/bjsapi/controllers/StudentScoreController.java Outdated Show resolved Hide resolved
api/src/test/java/com/bjs/bjsapi/controllers/StudentScoreControllerTest.java Outdated Show resolved Hide resolved
api/src/test/java/com/bjs/bjsapi/controllers/StudentScoreControllerTest.java Outdated Show resolved Hide resolved
api/src/test/java/com/bjs/bjsapi/controllers/StudentScoreControllerTest.java Outdated Show resolved Hide resolved
api/src/test/java/com/bjs/bjsapi/controllers/StudentScoreControllerTest.java Show resolved Hide resolved
@aykborstelmann aykborstelmann changed the title WIP #2 Calcuation of the score WIP #2 Calculation of the score Nov 22, 2019
liamskydamien and others added 4 commits November 24, 2019 13:20
@liamskydamien @aykborstelmann
Implement basic calculation
99d5577
@aykborstelmann
Implement calculation information.
1dfc77f
@liamskydamien @aykborstelmann
Add basic tests and refactor calculation
d9e9b6c 
Co-authored-by: Ayk Borstelmann <borstelmann.ayk@gmail.com>
@aykborstelmann @liamskydamien
Refactoring and add integration tests
3d12381 
Co-authored-by: skyliam <liamskydamien@gmail.com>
@aykborstelmann aykborstelmann changed the title WIP #2 Calculation of the score #2 Calculation of the score Nov 24, 2019
@aykborstelmann aykborstelmann merged commit fda55cb into master Nov 24, 2019
@aykborstelmann aykborstelmann deleted the feature/calculation-of-the-score branch November 24, 2019 12:36
@aykborstelmann
Copy link
Member Author

aykborstelmann commented Nov 24, 2019 •
edited
Loading

This closes #2 , thank you @skyliam 👍

@aykborstelmann aykborstelmann mentioned this pull request Dec 2, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aykborstelmann aykborstelmann

Labels
feature A new feature to add
Projects
None yet
Milestone
Basic Functionality
Development

Successfully merging this pull request may close these issues.
2 participants
@aykborstelmann @liamskydamien