-
Notifications
You must be signed in to change notification settings - Fork 164
added identity provider for ZfcUserDoctrineODM #217
added identity provider for ZfcUserDoctrineODM #217
Conversation
@bjyoungblood is this provider ok for merging it enabled support for the ZFC User ODM module |
Totally missed this PR, sorry! Reviewing right now. |
@@ -77,6 +77,8 @@ | |||
'BjyAuthorize\Collector\RoleCollector' => 'BjyAuthorize\Service\RoleCollectorServiceFactory', | |||
'BjyAuthorize\Provider\Identity\ZfcUserZendDb' | |||
=> 'BjyAuthorize\Service\ZfcUserZendDbIdentityProviderServiceFactory', | |||
'BjyAuthorize\Provider\Identity\ZfcUserDoctrineMongoODM' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is wrong here
Where's the actual mongodb stuff happening? |
@matwright looked at the code again and I thought that the new provider seems a bit redundant with the The only difference between the two is that you'd Thoughts? |
@Ocramius yep you are absolutely correct. The AuthenticationIdenityProvider does everything so providing ZfcUser has its own MongoDB adapter for roles/user entities that will do the job. |
@matwright so can I close this or is there anything that should still be enhanced? |
@Ocramius this PR can be closed. Many thanks for taking the time to review. |
For Info, the ZfcUserDoctrineODM module is now available on packagist I have sent a seperate PR to add this in the composer suggests #241 |
Identity provider to enable support for ZfcUserDoctrineODM with BjyAuthorize.