Skip to content
This repository has been archived by the owner on May 14, 2018. It is now read-only.

added identity provider for ZfcUserDoctrineODM #217

Closed

Conversation

matwright
Copy link
Contributor

Identity provider to enable support for ZfcUserDoctrineODM with BjyAuthorize.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.47%) when pulling 910e902 on matwright:zfc_user_doctrine_mongo_odm into d9a40af on bjyoungblood:master.

@matwright
Copy link
Contributor Author

@bjyoungblood is this provider ok for merging it enabled support for the ZFC User ODM module

@Ocramius
Copy link
Contributor

Totally missed this PR, sorry! Reviewing right now.

@@ -77,6 +77,8 @@
'BjyAuthorize\Collector\RoleCollector' => 'BjyAuthorize\Service\RoleCollectorServiceFactory',
'BjyAuthorize\Provider\Identity\ZfcUserZendDb'
=> 'BjyAuthorize\Service\ZfcUserZendDbIdentityProviderServiceFactory',
'BjyAuthorize\Provider\Identity\ZfcUserDoctrineMongoODM'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is wrong here

@Ocramius
Copy link
Contributor

Where's the actual mongodb stuff happening?

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.7%) when pulling 59a7fcf on matwright:zfc_user_doctrine_mongo_odm into d9a40af on bjyoungblood:master.

@Ocramius
Copy link
Contributor

@matwright looked at the code again and I thought that the new provider seems a bit redundant with the AuthenticationIdentityProvider.

The only difference between the two is that you'd new AuthenticationIdentityProvider($userService->getAuthService()).

Thoughts?

@matwright
Copy link
Contributor Author

@Ocramius yep you are absolutely correct. The AuthenticationIdenityProvider does everything so providing ZfcUser has its own MongoDB adapter for roles/user entities that will do the job.

@Ocramius
Copy link
Contributor

@matwright so can I close this or is there anything that should still be enhanced?

@matwright
Copy link
Contributor Author

@Ocramius this PR can be closed. Many thanks for taking the time to review.

@matwright
Copy link
Contributor Author

For Info, the ZfcUserDoctrineODM module is now available on packagist I have sent a seperate PR to add this in the composer suggests #241

@matwright matwright closed this May 15, 2014
@matwright matwright deleted the zfc_user_doctrine_mongo_odm branch May 15, 2014 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants