Makefile wholearchive responsefile support #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues with many objects yielding a command line too long.
|
On second thought, I think it would be easier to just review and merge this PR instead of the 2. |
rhoot
reviewed
Jul 15, 2019
This reverts commit 66f9284.
- depend on libdeps - iterate over lddeps to write responsefile This conserves the order of dependency
KageKirin
force-pushed
the
makefile-wholearchive-attfile
branch
from
16a45a9
to
ad9cb41
Compare
|
I'm still testing, but I think I have a fix for the issue raised by @rhoot. |
KageKirin
force-pushed
the
makefile-wholearchive-attfile
branch
from
ad9cb41
to
23e33e1
Compare
|
So, I finished testing this (by building my work project for Android), and it works. @rhoot Could you please review this again? Thanks. |
|
Hey @bkaradzic and @rhoot, Especially if there are things to fix or improve, I'd like to get feedback about them. |
|
Happy thanksgiving. |
|
Yeah waiting for @rhoot to review it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is the PR for the follow up changes to #456 I mentioned in the latter's PR.
This PR adds handling of wholearchive libs with responsefiles.
(Simply said, I had to link several libs as wholearchive for Android, and ran into this self-created bug).
The actual changes from this PR starts after b5a3826, the part before being the previous work to be as #456.
Cheers.
CC @rhoot for review as well, please.