New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaderc.cpp incorrectly adds PSSL preamble to compute shader #3205

Closed

00bins opened this issue Nov 20, 2023 · 1 comment

Contributor

00bins commented Nov 20, 2023

Line 1550 of shaderc.cpp reads

if (profile->lang != ShadingLang::PSSL)
{
	preprocessor.writef(getPsslPreamble() );
}

should read

if (profile->lang == ShadingLang::PSSL)
{
	preprocessor.writef(getPsslPreamble() );
}

This is only a problem if you have pssl support and getPsslPreamble() doesn't return ""

The text was updated successfully, but these errors were encountered:

Owner

bkaradzic commented Nov 20, 2023

Send PR with fix.

bkaradzic closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment