Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan backend implementation 4: multiple vertex streaming #1852

Merged
merged 1 commit into from Aug 11, 2019

Conversation

rinthel
Copy link
Contributor

@rinthel rinthel commented Aug 11, 2019

Hello, this is the 4th PR of my vulkan backend implementation (#274) !

Changes

  • Multiple vertex streaming is implemented! In order to support this, pipeline creation process and bindings of vertex buffers are modified.
  • Some additional condition handling codes are added for devices that don't have debug_utils extension (it was needed when I run the examples on my android device, which does not have EXT_debug_utils extensions...)
  • After enumerating present modes that are supported by hardware, choose the preferred present mode first and set it.
    • currently, the order of present modes is FIFO, FIFO relaxed, Mailbox, and Immediate.
    • I referred the vulkan reference book to pick FIFO at first.
  • During render pass creation, attachment's load and store operations are set by LOAD and STORE, instead DONT_CARE. So initial layouts of image are changed to ATTACHMENT_OPTIMAL instead of UNDEFINED.
  • Fix resolve attachment reference setup during render pass creation. I think that it was the main reason that crashes example 19 and some others.

Status

  • Now almost examples are executable, except to those which use compute shaders.

Thank you for reading. Please let me know if you have any question!

- additional condition for devices that don't have debug_utils extension
- set FIFO present mode if possible
- fix attachment load and store operation and its image layout during render pass creation
- fix resolve attachment reference setup during render pass creation
- implement multiple vertex stream
@bkaradzic bkaradzic merged commit 2b5246f into bkaradzic:master Aug 11, 2019
@bkaradzic
Copy link
Owner

Works with AMD on Linux now. 👍

@rinthel rinthel deleted the vulkan-support-04-mvs branch August 12, 2019 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants