Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NetBSD support. #61

Closed
wants to merge 3 commits into from
Closed

Add NetBSD support. #61

wants to merge 3 commits into from

Conversation

0-wiz-0
Copy link
Contributor

@0-wiz-0 0-wiz-0 commented Jul 14, 2015

The one path to freebsd in scripts/toolchain.lua is by purpose, NetBSD needs the same compatibility headers.
Signed-off-by: Thomas Klausner wiz@NetBSD.org

@0-wiz-0 0-wiz-0 mentioned this pull request Jul 14, 2015
Merged
@0-wiz-0
Add NetBSD support.
60c1cba 
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
@0-wiz-0
Add more NetBSD support.
8989ef7
@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Nov 13, 2015

I've now added a genie binary to the commit.
Does that make it more acceptable?
Please give feedback what you need to get this merged.

0-wiz-0 added a commit to 0-wiz-0/mame that referenced this pull request Nov 13, 2015
@0-wiz-0
bx: add NetBSD support.
79fb7f4 
I've filed a more complete patch for this upstream:

bkaradzic/bx#61

but this has been ignored since June. This patch is the minimal
set to fix the build on NetBSD.
@bkaradzic
Copy link
Owner

Reason why I don't want to accept it is because there is no difference between _FREEBSD and _NETBSD. Basically _FREEBSD needs to become _BSD and that's it.

@bkaradzic bkaradzic closed this Nov 13, 2015
@bkaradzic
Copy link
Owner

This:

 #elif defined(__FreeBSD__) || defined(__NetBSD__)
 #  undef  BX_PLATFORM_FREEBSD
 #  define BX_PLATFORM_FREEBSD 1

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Nov 13, 2015

Ok, some more questions then:

  • Should it be "BX_PLATFORM_BSD" then?
  • NetBSD binaries do not run on FreeBSD. Do you see that as a problem? They'll share a directory.
  • What do you want to happen in the toplevel makefile?

@bkaradzic
Copy link
Owner

  1. Don't rename defines for now, just add || defined(__NetBSD__) to define BX_PLATFORM_FREEBSD, I'll unify/rename those once you confirm there are no other changes to source code needed specifically for NetBSD.
  2. Add netbsd to bx/scripts/toolchain.lua, just follow FreeBSD, so they build to different destination directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0-wiz-0 @bkaradzic