Re-add NetBSD support. #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes linking on Unix when SDL is disabled. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
bkaradzic/bgfx@e1a564c#diff-d51370988baf340d4de0bc2861591415 Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Will try sending this upstream as well. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Even the Linux man page recommends avoiding ftime(). gettimeofday is in POSIX.1-2001 and more portable. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
|
Can you pull-request the BGFX fixes to https://github.com/bkaradzic/bgfx ? |
| return FILERR_FAILURE; | ||
|
|
||
| result = ftruncate(fileno((FILE *)file), offset); | ||
| if (!result) |
There was a problem hiding this comment.
ftruncate returns 0 on success. See recent change 2fe1b16
There was a problem hiding this comment.
Thanks, fixed and another patch added to pull request.
|
There is no change necessary for BGFX; the patch for that is pulled from upstream. |
Noted by startaq in mamedev#257. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Jul 15, 2015
NullPopPoLab
pushed a commit
to NullPopPoLab/GroovyMAME
that referenced
this pull request
Jan 29, 2023
…-0.235 Revert "libretro/mame 0.235"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the change in the build system and additional bx/bgfx libraries, mame didn't build on NetBSD any longer.
The patches in this pull request fix this. Please take as much as possible, though I would understand that you want to avoid changing 3rdparty code.
In that case, let me know how to prepare the changes so you can take what you want as easily as possible.
Thanks.