modifiy conditional branch #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Thank you for your contribution! Merging this in. |
|
@cadwallion @takakuda I think this breaks dotenv in cli because |
y-yagi
added a commit
to y-yagi/dotenv
that referenced
this pull request
Jun 24, 2019
…ons_change" This reverts commit 00e14aa, reversing changes made to f796d36. Reason: The pure Ruby doesn't have `Array#present?`. So this cause `NoMethodError` when using dotenv without Rails. ``` $ dotenv -t .env Traceback (most recent call last): 3: from /bin/dotenv:23:in `<main>' 2: from /bin/dotenv:23:in `load' 1: from /lib/ruby/gems/2.5.0/gems/dotenv-2.7.3/bin/dotenv:4:in `<top (required)>' /lib/ruby/gems/2.5.0/gems/dotenv-2.7.3/lib/dotenv/cli.rb:25:in `run': undefined method `present?' for []:Array (NoMethodError) Did you mean? prepend ```
|
Thank you for reverting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think modifiy
unless -> ifeasy to understand.my english is weak...
i`m sorry!