Kestrel #88
Kestrel #88
Conversation
|
/cc @grantr |
| s.files = `git ls-files -- lib | grep sqs`.split("\n") | ||
| s.require_paths = ["lib"] | ||
|
|
||
| s.add_dependency 'thrift_client', '~> 0.8.0' |
There was a problem hiding this comment.
Might want to update this to '~> 0.9.0' to avoid twitter/thrift_client#49
There was a problem hiding this comment.
There was some downside to 0.9+, but I cannot remember what it was. I updated to 0.9.2 locally and it worked, though I did have to add rack and thin to gemspec, oddly enough.
|
Nice! Is there not a kestrel gem? Seems like qu shouldn't have to have all that thrift stuff vendored. 2¢ |
|
There is not one that uses the thrift interface, which we use for github analytics and I trust relatively well. I can definitely move that part out to a gem and test it separately. |
Had to add thin, which is stupid. Need to see about removing that as a dependency by fixing requires. I think it is only used in the thrift server, not the client stuff.
|
Closing this. I have an unfinished kestrel client based on thrift here: https://github.com/jnunemaker/prey. If/when I finish that, I'll re-open this. |
Adds kestrel backend.