Use Queue in memory backend #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queue is more likely to behave correctly when threads are involved. Default Queue#pop is blocking, but use nonblocking here to preserve nonblocking semantics.
Keeping the nil check anyway to preserve existing behavior.
| rescue ThreadError => e | ||
| unless e.message =~ /queue empty/ | ||
| raise e | ||
| end |
There was a problem hiding this comment.
Could this use #empty? to avoid the exception?
|
Is thread-safety the primary motivation for this? |
Avoids constant exception/rescue on an idle queue.
|
Thread safety is the only motivation for this. I can't imagine it will be faster. If you're confident in the current thread-safe-ness, I don't see a good reason to merge. Starting to seem like a worse idea all the time! 😉 |
|
Looks like the code already uses a Monitor, which should make it threadsafe. |
|
oops, didn't mean to close. |
|
Monitor should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is an improvement or not, but it was easy to try. Popping an empty queue now requires exception handling, so there might be a performance degradation. If so it's probably not worth the change.