Remove dependency on ANTLR3 and antlr4-maven-plugin #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency should only be required at compile time. It was being bundled with the project and bringing other libraries with it.
|
Any chance of this going in and new release soonish? Dependencies pulled by antlr4-maven-plugin also have known security vulnerabilities, so all the more reason to get rid of them. |
|
Many thanks @JD557! |
|
@bkiers, Amazing! Thanks! |
|
No problem, for release notes, see: https://github.com/bkiers/Liqp/releases/tag/0.7.5 0.7.5 is available in Maven Central: https://search.maven.org/artifact/nl.big-o/liqp/0.7.5/jar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK, the
antlr4-maven-plugindependency is only needed at compile time.It was being included and available at runtime, bringing with it a lot of dependencies (see #98)
This PR removes the dependency on that library at runtime and the dependencies on
edu.emory.mathcs.backportand ANTLR3 (both those libraries were available thanks to the plugin).I think that everything is working as expected, but ANTLR4 uses different Exceptions. When reviewing this PR, please check if the new
LiquidExceptionmessages make sense.