Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ARROW-8962: [C++] Add explicit implementation for junk values
When linking the tests with `clang-4.0`, I get ``` Undefined symbols for architecture x86_64: "arrow::internal::(anonymous namespace)::StringToFloatConverterImpl::main_junk_value_", referenced from: arrow::internal::StringToFloat(char const*, unsigned long, float*) in libarrow.a(value_parsing.cc.o) arrow::internal::StringToFloat(char const*, unsigned long, double*) in libarrow.a(value_parsing.cc.o) "arrow::internal::(anonymous namespace)::StringToFloatConverterImpl::fallback_junk_value_", referenced from: arrow::internal::StringToFloat(char const*, unsigned long, float*) in libarrow.a(value_parsing.cc.o) arrow::internal::StringToFloat(char const*, unsigned long, double*) in libarrow.a(value_parsing.cc.o) ld: symbol(s) not found for architecture x86_64 ``` These older clang versions need an explicit implementation definition. Closes apache#7286 from xhochy/ARROW-8962 Authored-by: Uwe L. Korn <uwe.korn@quantco.com> Signed-off-by: François Saint-Jacques <fsaintjacques@gmail.com>
- Loading branch information