Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: #77 Error Refactoring #78

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

bkonkle
Copy link
Owner

@bkonkle bkonkle commented Dec 8, 2023

Implements #77

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (3c99700) 61.70% compared to head (a3a120e) 61.36%.

❗ Current head a3a120e differs from pull request most recent head d7776fd. Consider uploading reports for the commit d7776fd to get more accurate results

Files Patch % Lines
nakago/src/inject/hooks.rs 30.00% 7 Missing ⚠️
nakago/src/inject/errors.rs 0.00% 6 Missing ⚠️
nakago/src/app.rs 71.42% 2 Missing ⚠️
nakago/src/inject/provider.rs 66.66% 2 Missing ⚠️
nakago_axum/src/app.rs 0.00% 2 Missing ⚠️
nakago_axum/src/auth/validator.rs 0.00% 2 Missing ⚠️
nakago_axum/src/routes.rs 0.00% 2 Missing ⚠️
nakago_sea_orm/src/connection.rs 0.00% 2 Missing ⚠️
nakago_async_graphql/src/schema.rs 0.00% 1 Missing ⚠️
nakago_async_graphql/src/test/utils.rs 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   61.70%   61.36%   -0.34%     
==========================================
  Files          36       36              
  Lines        2209     2226      +17     
==========================================
+ Hits         1363     1366       +3     
- Misses        846      860      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkonkle bkonkle merged commit 3e85d32 into main Dec 8, 2023
1 of 2 checks passed
@bkonkle bkonkle deleted the feature/77-error-refactoring branch December 8, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant