Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ver 5.0.0 Feedback Thread #351

Merged
merged 462 commits into from
Apr 26, 2022
Merged

Ver 5.0.0 Feedback Thread #351

merged 462 commits into from
Apr 26, 2022

Conversation

black7375
Copy link
Owner

@black7375 black7375 commented Mar 27, 2022

Describe the PR

Build using SCSS, and have optional systems.


Setup - Please refer Wiki:Installation Guide

  1. Download files
## First user ##################################################################
# At <FIREFOX_PROFILE_DIRECTORY>

# Original dev version
git clone https://github.com/black7375/Firefox-UI-Fix -b dev

# Photon style dev version
git clone https://github.com/black7375/Firefox-UI-Fix  chrome -b photon-style-dev

# Proton style dev version
git clone https://github.com/black7375/Firefox-UI-Fix chrome -b proton-style-dev

## Existing user ###############################################################
# At <FIREFOX_PROFILE_DIRECTORY>/chrome

# Original dev version
git checkout dev
git pull

# Proton style dev version
git checkout photon-style-dev
git pull

# Proton style dev version
git checkout proton-style-dev
git pull
  1. Copy user.js to profile directory
    ⚠️ You must copy user.js file before the theme works.
    The option system depends on user configuration, and nothing applies without settings.
  2. Restart firefox

Customize

You can be customized using the following file:

⚠️ However, there are several caveats.

  1. File user.js must modify the file located in <FIREFOX_PROFILE>/user.js, not <FIREFOX_PROFILE>/chrome/user.js.
  2. It can be configurable with user.js file and about:config and needs to be restarted.
    The option system is built using CSS -moz-bool-pref() @supports function as a base.
    @supports change in CSS is not detected in real time. (Only start time)
    So a restart is required, and if the mozilla need real time changes, are using @media to handle it.
    However, since this project only use pure CSS, we cannot add @media rules.
  1. After editing user.js file, click the Clear startup cache... in about:support.
    If the Clear startup cache... button is not used, the setting may be overridden.
  2. Even if you change the setting in about:config, it will not take effect if it remains in user.js.
    It is recommended to explicitly change the value in the user.js file.
  3. If you remove a setting from the user.js file, the last value is preserved.
    It is recommended to explicitly change the value to false in the user.js file.

Related Issue

Main

Additional

Frequency user requirements cc75c6a 1943c5c

Customize

Other

Screenshots

image

Using dev branch and the following settings

  • userChrome.tab.on_bottom
  • userChrome.tab.on_bottom.menubar_on_top

Additional context

You can suggest compatibility issues, option names, etc.

@roland-5
Copy link
Contributor

roland-5 commented Apr 24, 2022

I created chrome folder with

css
icons
src
userChrome.css
userContent.css

And with user.js in main profile folder and everything works without problem. Looks great! Every change I made to user.js worked and were clear how to use. Awesome work you made. <3

Does this files are needed in chrome folder?

docs
package.json
yarn.lock

@black7375
Copy link
Owner Author

They contain the information needed for development.

This document may be helpful.
https://github.com/black7375/Firefox-UI-Fix/blob/dev/docs/Project_Structure.md

@black7375 black7375 merged commit 0fd746b into master Apr 26, 2022
@MonfGeiger
Copy link

MonfGeiger commented May 4, 2022

so let me try to parse this one more time: we could try and change the userchrome flags through about:config all we want, but no matter what, those values will NEVER truly (at this moment) apply that way. we would have to edit those flags into the user.js file (if not already included) and set them that way after following the steps in this feedback thread.

that is.....frankly annoying. I thought we could set the values through firefox itself by now, but we still have to do it manually, or edit the userchrome folder directly. my apologies for my griping, but will we ever truly be able to set userchrome flags through firefox's about:config page any time soon, or is that just never happening no matter what?

@black7375
Copy link
Owner Author

@MonfGeiger

It's possible using only about:config.
The limit of using about:config is that it is initialized every time with the settings in the user.js file.

What we can see here:

  1. If the setting is not enabled by default, you can only use about:config.
  2. If you need to touch the default settings, you can delete user.js after running once.

This is why the wiki document is written to delete the file.
https://github.com/black7375/Firefox-UI-Fix/wiki/Options#using-aboutconfigs

@MonfGeiger
Copy link

.....my potato brain did not see that until now. forgive my big brain move, I have indeed deleted the thing and I see it working again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Code Code quality and project structure, etc Issue::Enhancement New feature or request Priority::High Solve and focus on it first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants