Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lepton stylesheets into their own files #352

Closed
wants to merge 1 commit into from

Conversation

anzz1
Copy link

@anzz1 anzz1 commented Apr 7, 2022

Describe the PR

Move lepton stylesheets into their own files. This allows users to easily update lepton while still keeping
their own custom styles.

  • Move userChrome.css -> leptonChrome.css
  • Move userContent.css -> leptonContent.css
  • Replace userChrome and userContent with stubs which import lepton

Related Issue
None

Environment (please complete the following information):

* userChrome.css -> leptonChrome.css
* userContent.css -> leptonContent.css
* Replace userChrome and userContent with stubs which import lepton

This allows users to easily update lepton while still keeping
their own custom styles
@anzz1
Copy link
Author

anzz1 commented Apr 7, 2022

Actually even better would be to put lepton inside it's own folder, like in this example here: https://github.com/stonecrusher/simpleMenuWizard/blob/master/userChrome.css

@black7375
Copy link
Owner

I think it's a good suggestion to make your custom easier.
It could be a bigger change than expected for those who have customized it before, so I will apply it in #351 and proceed it all at once.

@black7375 black7375 mentioned this pull request Apr 8, 2022
14 tasks
@hdk5
Copy link

hdk5 commented Apr 14, 2022

Actually even better would be to put lepton inside it's own folder, like in this example here: https://github.com/stonecrusher/simpleMenuWizard/blob/master/userChrome.css

Just want to let you know that I had my lepton (with some personal extras) installation set up like this for quite a while, and also updated via git, and it works perfectly. Like this.

So yeah, I think providing advanced setup instructions would work better.

@anzz1
Copy link
Author

anzz1 commented Apr 18, 2022

@hdk5 , oh yeah. Of course. How on earth did I not think about that? That is definitely the best course of action. Doing it like that works perfectly as-is right now, one idea for improvement would be to maybe edit the installation guide and the installation script though.

One way it could be improved imo, to maybe make it download the github repo to its' own "lepton" folder under the "chrome" like @hdk5 has it, and then check whether the files user.js, userchrome.css and usercontent.css exist already. If not, create the stubs for loading lepton, if yes, show a message to user "you have a existing theme/user.js settings installed, do you want to overwrite it with stubs [y/n] y = overwrite , n = show information about what import lines you need to add manually.

This is kinda low-priority though, I mean it could be good to include it as a part of the larger overhaul when it's changing a major version number and a restructure anyway, but if you probably have more important stuff to do and strapped on time, this is not too important to do right now.

In any case this particular PR is obsolote and can be closed, or if you want to keep it as an open PR for the discussion part (and as a "reminder"), that's good too. Whichever you think is best.

And I separately want to thank you for ongoing support for Win7, which many developers have started to drop nowadays which is a shame. I love your work and this project and firefox with the photon-style, and am glad I still can keep using it on my OS of choice.

@black7375
Copy link
Owner

black7375 commented Apr 19, 2022

Recently, I've been working on cutomize script.
I think the structure of @hdk5 is quite good because VCS is independent.
There is certainly less risk of conflict.


However, due to backward compatibility, complex script problems, the script itself may be implemented using git stash.

@black7375
Copy link
Owner

black7375 commented Apr 21, 2022

I have written a simple script.

bash -c "$(curl -fsSL https://raw.githubusercontent.com/black7375/Firefox-UI-Fix/dev/install.sh)"
Powershell -c "Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iwr https://raw.githubusercontent.com/black7375/Firefox-UI-Fix/dev/install.ps1 -useb | iex"

When installing or updating, it applies if you have user-overrides.js, userChrome-overrides.css, userContent-overrides.css files in the current directory (priority high) or installation(<FIREFOX_PROFILE>/chrome/) directory.

black7375 added a commit that referenced this pull request Apr 23, 2022
black7375 added a commit that referenced this pull request Apr 24, 2022
@black7375
Copy link
Owner

This proposal was reflected in #351

@black7375 black7375 closed this Apr 26, 2022
@black7375 black7375 added the Issue::Code Code quality and project structure, etc label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Code Code quality and project structure, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants