This repository has been archived by the owner on May 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-BrandonJones
requested review from
Blackbaud-BobbyEarl,
Blackbaud-PaulCrowder,
Blackbaud-SteveBrush and
Blackbaud-TimPepper
March 11, 2019 19:25
* added ability to use extended configs from the help widget * tests * clean up * using node 10, updated key to use data
Blackbaud-BobbyEarl
approved these changes
Mar 29, 2019
Blackbaud-BrandonJones
added a commit
that referenced
this pull request
May 1, 2019
* added dev config file * created a dev server for the help widget * added style sheets * added style loader to prod config, removed options * base help widget wrapper code * tweaks * Feature Dev Server (#14) * added dev config file * created a dev server for the help widget * added style loader to prod config, removed options * moved to dev dep * removing identname * post message, close, and config sending * cleaning up help widget * moved communication service to help.ts file * added a comment and clean up * created widget separate from renderer * beginning clean up * accessible invoker * enable/disable widget methods * update scss imports (#17) * Linting testing updates (#18) * update scss imports * getting testing environment ready * linting fixed * help.ts tests complete' * renderer tests * starting help widget tests * tests started * tests for the help widget * communication service * all tests * added a comment note about the rgb values * clean up and removed unused variable * clean up * Add get whats new revision (#16) * add getWhatsNewRevision logic * fix linting issue * update scss imports * getting testing environment ready * linting fixed * help.ts tests complete' * renderer tests * starting help widget tests * tests started * tests for the help widget * communication service * all tests * added a comment note about the rgb values * clean up and removed unused variable * clean up * update getWhatsNewRevision return type and tests * add test * Bugfix button height (#19) * shrinking button by 1 px to match the header * unused style * header and button style tweaks * center invoker icon and remove border and outline (#21) * Feature host params (#24) * center invoker icon and remove border and outline * host params * Add new message when closing the help client (#23) * add close message * remove logging * Feature in file css (#25) * updated css to be loaded in file isntead of separate css files * removed no longer necessary scss files * removed files and references * outline is needed for visual que when selecting item via keyboard (#26) * add mobile view logic (#22) * add mobile view logic * move mobile view logic to class-based methodology * update tests * update mobile size * move logic back to media queries * Hide on mobile (#27) * fixes bouncing bug on mobile sizes * tests implemented * Add mixpanel integration (#20) * add mixpanel to open/close buttons * update authEnabled usage * add analytics service tests * add new directory * remove console log * fix test config * remove user logging * remove unecessary dependencies * refine analytics service vars * remove test * checking if in SKYUX 2 host dev mode (#28) * checking if in SKYUX 2 host dev mode * updated comment * window ref and tests * add close message (#30) * Update current help key (#29) * add close message * update current help key logic * update logic for transmitting current help key * remove comment * update wait logic * fix test * remove ready logic on setCurrentHelpKey * Support get current key (#31) * added support for passing in a getCurrentHelpKey method * updating getCurrentHelpKey logic * tests * removed f describe * removed . * removed uncessary error log (#32) * removed uncessary error log * removed comment * updated test * updated dependencies (#33) * updated dependencies * updated dependency * focus invoker (#34) * Update accessibility (#35) * jump to widget on open * remove console output * fix spacing (#37) * fix spacing * update package name * update package name * test rc versioning in skyux-deploy * update version * update project name * updated to use dependency injection (#38) * updated to use dependency injection * using test config * Review updates (#39) * updated to use dependency injection * using test config * updated mixpanel key import for testing * updated file name * Feature extended config (#40) * added ability to use extended configs from the help widget * tests * clean up * using node 10, updated key to use data * fixed broken test * removed spacing * compress and ugilfy * updated client const methods to come after imports * remove package-lock * added package-lock to gitignore * added pipeline settings to package json * updated version * removing prepare package in favor of pipeline * updated beta version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.