This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
RC > Replace JSCS/JSHint with ESLint #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc-2.0.0 #506 +/- ##
=======================================
Coverage 100% 100%
=======================================
Files 54 54
Lines 1709 1707 -2
Branches 249 249
=======================================
- Hits 1709 1707 -2
Continue to review full report at Codecov.
|
| const libFiles = libPaths.reduce((accumulator, libPath) => | ||
| accumulator.concat( | ||
| const libFiles = libPaths.reduce((accumulator, libPath) => { | ||
| return accumulator.concat( |
There was a problem hiding this comment.
Does adding return here change the functionality at all?
There was a problem hiding this comment.
Never mind. I just realized you added curly braces around it so that adding return makes it equivalent to the previous code. I'm curious as to what rule the original code broke, though.
There was a problem hiding this comment.
No, since the previous version is returning the value of accumulator.concat implicitly. ESlint was complaining about the format of the arrow function, so writing it out explicitly shouldn't affect the end result.
Blackbaud-PaulCrowder
approved these changes
Jan 4, 2019
Blackbaud-DiHuynh
pushed a commit
to Blackbaud-DiHuynh/skyux-builder
that referenced
this pull request
Jul 10, 2020
* RC > Removed all references to SKY UX, changed dependency structure (blackbaud#419) * RC > Updated TSLint rules (blackbaud#422) * Removed legacy omnibar (blackbaud#420) * RC > Config params as an object; always decode URL params (blackbaud#421) * RC > Always provide `envId` regardless of permission scope (blackbaud#427) * RC > Allow SPAs to bundle stylesheets that live outside of `src/app` (blackbaud#428) * RC > Adjusted dev dependencies (blackbaud#429) * RC > Fixed ts-helpers for build (blackbaud#434) * RC > Update from master (blackbaud#425) * RC > Removed global RxJS imports (blackbaud#438) * RC > Replaced error component with iframe (blackbaud#436) * RC > Removed SKY CSS import (blackbaud#443) * RC > Instrument different directory for libraries (blackbaud#448) * RC > Do not ignore Protractor Error 199 (blackbaud#435) * RC > Merged master (blackbaud#444) * RC > Merge master (blackbaud#454) * RC > Upgrade Angular, RxJS, TypeScript (blackbaud#495) * RC > Moved auth-client to peer dependency; fixed `skyux watch` (blackbaud#503) * Disabled webpack host check (blackbaud#505) * Replaced JSHint with ESLint. (blackbaud#506) * RC > Merge master (blackbaud#508) * RC > Changed name of NPM package (blackbaud#501)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.