This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
RC > Merged master #444
Merged
RC > Merged master #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Listening to postMessage if during e2e. * Added test * Using navigate instead of navigateByUrl * Added sky prefix.
* Updated CHANGELOG.md and package.json for 1.18.0 * Update CHANGELOG.md
* Exposing the skyPagesConfig to karma and protractor configs. * Cleanup * Allowing device property * Allow all properties * Fixing type * Allowing supported property. * Using browserSet instead of browsers + supported. * Removed enums. * Update schema properties.
* Initial commit of skyuxconfig.json schema * Allowing $schema property * Added codeCoverageThreshold
* Added option to exclude parameters from being added to requests sent by SkyAuthHttp * Added schema to base skyuxconfig.json file * Added params array items type
Codecov Report
@@ Coverage Diff @@
## rc-2.0.0 #444 +/- ##
============================================
+ Coverage 99.42% 99.42% +<.01%
============================================
Files 72 72
Lines 1900 1916 +16
Branches 297 302 +5
============================================
+ Hits 1889 1905 +16
Misses 11 11
Continue to review full report at Codecov.
|
* Fixed libraries unable to build on Windows * Added unit test * Modified error message
* Updated CHANGLOG.md and package.json for 1.19.2 * Update CHANGELOG.md
| @@ -82,6 +82,9 @@ describe('config webpack build public library', () => { | |||
| '@angular/common': '4.3.6', | |||
| '@pact-foundation/pact-web': '5.3.0', | |||
| 'zone.js': '0.8.10' | |||
| }, | |||
| peerDependencies: { | |||
| '@angular/core': '4.3.6' | |||
There was a problem hiding this comment.
Is this the behavior we want in RC?
There was a problem hiding this comment.
@Blackbaud-BobbyEarl I'm unsure exactly what you mean, but we definitely don't want libraries bundling peerDependencies (referring to this line: https://github.com/blackbaud/skyux-builder/pull/444/files#diff-054d421f3f99ee39229267add1ee72daR42).
|
@Blackbaud-BobbyEarl Let's get #449 merged before merging this pull request, if you don't mind. |
|
@Blackbaud-BobbyEarl This is ready for another look; please and thank you. |
Blackbaud-BobbyEarl
approved these changes
Aug 14, 2018
Blackbaud-DiHuynh
pushed a commit
to Blackbaud-DiHuynh/skyux-builder
that referenced
this pull request
Jul 10, 2020
* RC > Removed all references to SKY UX, changed dependency structure (blackbaud#419) * RC > Updated TSLint rules (blackbaud#422) * Removed legacy omnibar (blackbaud#420) * RC > Config params as an object; always decode URL params (blackbaud#421) * RC > Always provide `envId` regardless of permission scope (blackbaud#427) * RC > Allow SPAs to bundle stylesheets that live outside of `src/app` (blackbaud#428) * RC > Adjusted dev dependencies (blackbaud#429) * RC > Fixed ts-helpers for build (blackbaud#434) * RC > Update from master (blackbaud#425) * RC > Removed global RxJS imports (blackbaud#438) * RC > Replaced error component with iframe (blackbaud#436) * RC > Removed SKY CSS import (blackbaud#443) * RC > Instrument different directory for libraries (blackbaud#448) * RC > Do not ignore Protractor Error 199 (blackbaud#435) * RC > Merged master (blackbaud#444) * RC > Merge master (blackbaud#454) * RC > Upgrade Angular, RxJS, TypeScript (blackbaud#495) * RC > Moved auth-client to peer dependency; fixed `skyux watch` (blackbaud#503) * Disabled webpack host check (blackbaud#505) * Replaced JSHint with ESLint. (blackbaud#506) * RC > Merge master (blackbaud#508) * RC > Changed name of NPM package (blackbaud#501)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.