Removed labeled-by attribute from file input (#223)

* Removed labeled-by attribute from file input

* pr feedback

* Update src/app/public/modules/file-attachment/fixtures/file-attachment.component.fixture.ts

Co-authored-by: John Lyons <John.Lyons@blackbaud.com>

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Co-authored-by: John Lyons <John.Lyons@blackbaud.com>

package.json

@@ -60,7 +60,7 @@
     "@skyux/inline-form": "4.1.0",
     "@skyux/layout": "4.3.0",
     "@skyux/lists": "4.3.0",
-    "@skyux/lookup": "4.6.0",
+    "@skyux/lookup": "4.7.0",
     "@skyux/modals": "4.5.1",
     "@skyux/omnibar-interop": "4.0.1",
     "@skyux/popovers": "4.2.1",

src/app/public/modules/file-attachment/file-attachment.component.html

@@ -40,7 +40,6 @@
       class="sky-file-attachment-btn sky-btn sky-btn-default"
       type="button"
       [attr.aria-describedby]="fileDropDescriptionElementId"
-      [attr.aria-labelledby]="(hasLabelComponent) ? labelElementId : null"
       [disabled]="disabled"
       (click)="onDropClicked()"
     >

src/app/public/modules/file-attachment/file-attachment.component.spec.ts

@@ -15,7 +15,8 @@ import {
 } from '@angular/core';
 
 import {
-  expect
+  expect,
+  expectAsync
 } from '@skyux-sdk/testing';
 
 import {
@@ -1079,8 +1080,16 @@ describe('File attachment', () => {
 
   it('should pass accessibility', async(() => {
     fixture.detectChanges();
-    fixture.whenStable().then(() => {
-      expect(fixture.nativeElement).toBeAccessible();
+    fixture.whenStable().then(async () => {
+      await expectAsync(fixture.nativeElement).toBeAccessible();
+    });
+  }));
+
+  it('should pass accessibility when label does not match the button text', async(() => {
+    fixture.componentInstance.labelText = 'Something different';
+    fixture.detectChanges();
+    fixture.whenStable().then(async () => {
+      await expectAsync(fixture.nativeElement).toBeAccessible();
     });
   }));
 });

src/app/public/modules/file-attachment/fixtures/file-attachment.component.fixture.html

@@ -9,7 +9,7 @@
     <sky-file-attachment-label
       *ngIf="showLabel"
     >
-      Choose file
+      {{ labelText }}
     </sky-file-attachment-label>
   </sky-file-attachment>
 

src/app/public/modules/file-attachment/fixtures/file-attachment.component.fixture.ts

@@ -24,6 +24,8 @@ export class FileAttachmentTestComponent implements OnInit {
 
   public fileForm: FormGroup;
 
+  public labelText: string = 'Choose file';
+
   public required: boolean = false;
 
   public showLabel: boolean = true;