This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Removed labeled-by attribute from file input #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-AlexKingman
requested review from
Blackbaud-SteveBrush,
Blackbaud-TrevorBurch and
Blackbaud-ErikaMcVey
Blackbaud-SteveBrush
previously approved these changes
Oct 28, 2020
Blackbaud-TrevorBurch
suggested changes
Oct 28, 2020
| fixture.componentInstance.labelText = 'Something different'; | ||
| fixture.detectChanges(); | ||
| fixture.whenStable().then(() => { | ||
| expect(fixture.nativeElement).toBeAccessible(); |
There was a problem hiding this comment.
We should now be using expectAsync on these.
There was a problem hiding this comment.
There was a problem hiding this comment.
Done.
src/app/public/modules/file-attachment/file-attachment.component.spec.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 869 869
Branches 162 162
=========================================
Hits 869 869 Continue to review full report at Codecov.
|
src/app/public/modules/file-attachment/fixtures/file-attachment.component.fixture.ts
Outdated
Show resolved
Hide resolved
…t.component.fixture.ts Co-authored-by: John Lyons <John.Lyons@blackbaud.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#222