Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Merge 5.0.0 next #298

Merged
merged 30 commits into from Sep 30, 2021
Merged

Merge 5.0.0 next #298

merged 30 commits into from Sep 30, 2021

Conversation

johnhwhite
Copy link
Member

No description provided.

Alex Kingman and others added 22 commits June 8, 2021 11:04
Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
* provider updates, dependency updates, workflow updates

* revert

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
* Deprecate SkySelectionBoxGridAlignItems

* Export union type
* Input box inline help (#265)

* initial work

* character-count

* padding tweaks

* build fix

* fixed merge

* final positioning for inline help widget

* visual test tweak, test fix

* style tweaks

* updated selector to use sky-control-help

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>

* Build #skyux-forms-push-929062241-56873: Added new baseline screenshots. [ci skip]

* Update changelog/package.json for 4.19.0 release (#270)

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>

* Fix single file attachment to show full file name in title attribute (#271)

* Update changelog/package.json for 4.19.1 release (#272)

* Added left inset icon for input-box; fix padding bug with country field (#273)

* Added left inset icon for input-box

* visual tweaks

* unit tests

* added scss variables

* fix country field spacing

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>

* Build #skyux-forms-push-990175149-08428: Added new baseline screenshots. [ci skip]

* 4.20.0 release (#274)

* 4.20.0 release

* package lock

* Update CHANGELOG.md

Co-authored-by: Paula Hodgkins <77297281+blackbaud-paulah@users.noreply.github.com>

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Co-authored-by: Paula Hodgkins <77297281+blackbaud-paulah@users.noreply.github.com>
Co-authored-by: John Lyons <John.Lyons@blackbaud.com>

* Fix docs for checkbox (#276)

* Fix async disable selection box (#280)

* all changes associated to trying to fix the selection box disable bug... WIP for Alex's review

* complete disable selection-box unit test. fix broken radio disable test.

* remove unnecesary local experimentation leftovers

* typo

* fixing things according to Alex's comments

* remove editor ruler and word wrap

* fix template style guide violations

* add disable/enable button to /visual selection-box component

* correct typo and a style guide violation

* missed style guide violation

* update changelog. skyux upgrade. (#282)

* update changelog. skyux upgrade.

* Update CHANGELOG.md

Co-authored-by: John Lyons <John.Lyons@blackbaud.com>

* Update CHANGELOG.md

Co-authored-by: John Lyons <John.Lyons@blackbaud.com>

Co-authored-by: John Lyons <John.Lyons@blackbaud.com>

* Fix overlapping input box value and label for textareas in modern theme (#279)

* Fix overlapping input box value and label for textareas in modern theme

* reverted accidental comments

* removed baselines to allow for tiny shift in padding

* fixed visual test

* fix e2e test

* e2e fix

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Co-authored-by: Paul Crowder <paul.crowder@blackbaud.com>

* Build #skyux-forms-push-1049895399-36432: Added new baseline screenshots. [ci skip]

* Changelog update; redo 4.20.1 release (#283)

* changelog update

* Update CHANGELOG.md

Co-authored-by: John Lyons <John.Lyons@blackbaud.com>

* Update CHANGELOG.md

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Co-authored-by: John Lyons <John.Lyons@blackbaud.com>

* Removed accidental disabled e2e tests for input box (#284)

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>

Co-authored-by: Alex <alex.kingman@blackbaud.com>
Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
Co-authored-by: Blackbaud Sky Build User <sky-build-user@blackbaud.com>
Co-authored-by: Steve Brush <steve.brush@blackbaud.com>
Co-authored-by: Paula Hodgkins <77297281+blackbaud-paulah@users.noreply.github.com>
Co-authored-by: John Lyons <John.Lyons@blackbaud.com>
Co-authored-by: Braden Bisping <63625452+bradenbiz@users.noreply.github.com>
* Fix visual tests

* Fix import paths

* Update packages

* Delete screenshots
…#293)

* Removed modals

* 5.0.0-beta.5-release

* Update CHANGELOG.md

* baselines

Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
* Document sky-control-help class

* Update dependencies as per error messages

* package.lock

* reset baselines

Co-authored-by: John Lyons <John.Lyons@blackbaud.me>
Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me>
@johnhwhite johnhwhite self-assigned this Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #298 (8bf6b5f) into master (93c7767) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #298    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           37        34     -3     
  Lines         1098       788   -310     
  Branches       212       127    -85     
==========================================
- Hits          1098       788   -310     
Impacted Files Coverage Δ
...r-counter/character-counter-indicator.component.ts 100.00% <ø> (ø)
...s/character-counter/character-counter.directive.ts 100.00% <ø> (ø)
...s/src/modules/checkbox/checkbox-label.component.ts 100.00% <ø> (ø)
.../checkbox/checkbox-required-validator.directive.ts 100.00% <ø> (ø)
...s/forms/src/modules/checkbox/checkbox.component.ts 100.00% <ø> (ø)
...ects/forms/src/modules/checkbox/checkbox.module.ts 100.00% <ø> (ø)
...file-attachment/file-attachment-label.component.ts 100.00% <ø> (ø)
...modules/file-attachment/file-attachment.service.ts 100.00% <ø> (ø)
...src/modules/file-attachment/file-item.component.ts 100.00% <ø> (ø)
...s/src/modules/file-attachment/file-item.service.ts 100.00% <ø> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c7767...8bf6b5f. Read the comment docs.

@johnhwhite johnhwhite merged commit 68d3a99 into master Sep 30, 2021
@johnhwhite johnhwhite deleted the merge-5.0.0-next branch September 30, 2021 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants