This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
provider updates, dependency updates, workflow updates #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,7 +75,8 @@ import { | |||
| SkyFileSizePipe | |||
| ], | |||
| providers: [ | |||
| DecimalPipe | |||
| DecimalPipe, | |||
| SkyFileItemService | |||
There was a problem hiding this comment.
☝️ Used by both the SkyFileItemComponent and SkyFileAttachmentComponent.
| MutationObserverService, | ||
| SkyCoreAdapterService, | ||
| SkyThemeService | ||
| SkySelectionBoxAdapterService |
There was a problem hiding this comment.
☝️ Used by both the SkySelectionBoxGridComponent and SkySelectionBoxComponent.
Codecov Report
@@ Coverage Diff @@
## 5.0.0-next #277 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 37 38 +1
Lines 1081 1082 +1
Branches 210 210
============================================
+ Hits 1081 1082 +1
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
approved these changes
Jul 7, 2021
johnhwhite
added a commit
that referenced
this pull request
Sep 30, 2021
* initial commit * Updated singletons to use providedIn: root (#269) Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * Merge from master (#275) Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * provider updates, dependency updates, workflow updates (#277) * provider updates, dependency updates, workflow updates * revert Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * 5.0.0-beta.0 release (#278) Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * Deprecate SkySelectionBoxGridAlignItems (#281) * Deprecate SkySelectionBoxGridAlignItems * Export union type * Merge master into 5.0.0-next (#285) * Input box inline help (#265) * initial work * character-count * padding tweaks * build fix * fixed merge * final positioning for inline help widget * visual test tweak, test fix * style tweaks * updated selector to use sky-control-help Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * Build #skyux-forms-push-929062241-56873: Added new baseline screenshots. [ci skip] * Update changelog/package.json for 4.19.0 release (#270) Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * Fix single file attachment to show full file name in title attribute (#271) * Update changelog/package.json for 4.19.1 release (#272) * Added left inset icon for input-box; fix padding bug with country field (#273) * Added left inset icon for input-box * visual tweaks * unit tests * added scss variables * fix country field spacing Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * Build #skyux-forms-push-990175149-08428: Added new baseline screenshots. [ci skip] * 4.20.0 release (#274) * 4.20.0 release * package lock * Update CHANGELOG.md Co-authored-by: Paula Hodgkins <77297281+blackbaud-paulah@users.noreply.github.com> Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: Paula Hodgkins <77297281+blackbaud-paulah@users.noreply.github.com> Co-authored-by: John Lyons <John.Lyons@blackbaud.com> * Fix docs for checkbox (#276) * Fix async disable selection box (#280) * all changes associated to trying to fix the selection box disable bug... WIP for Alex's review * complete disable selection-box unit test. fix broken radio disable test. * remove unnecesary local experimentation leftovers * typo * fixing things according to Alex's comments * remove editor ruler and word wrap * fix template style guide violations * add disable/enable button to /visual selection-box component * correct typo and a style guide violation * missed style guide violation * update changelog. skyux upgrade. (#282) * update changelog. skyux upgrade. * Update CHANGELOG.md Co-authored-by: John Lyons <John.Lyons@blackbaud.com> * Update CHANGELOG.md Co-authored-by: John Lyons <John.Lyons@blackbaud.com> Co-authored-by: John Lyons <John.Lyons@blackbaud.com> * Fix overlapping input box value and label for textareas in modern theme (#279) * Fix overlapping input box value and label for textareas in modern theme * reverted accidental comments * removed baselines to allow for tiny shift in padding * fixed visual test * fix e2e test * e2e fix Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: Paul Crowder <paul.crowder@blackbaud.com> * Build #skyux-forms-push-1049895399-36432: Added new baseline screenshots. [ci skip] * Changelog update; redo 4.20.1 release (#283) * changelog update * Update CHANGELOG.md Co-authored-by: John Lyons <John.Lyons@blackbaud.com> * Update CHANGELOG.md Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: John Lyons <John.Lyons@blackbaud.com> * Removed accidental disabled e2e tests for input box (#284) Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: Alex <alex.kingman@blackbaud.com> Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: Blackbaud Sky Build User <sky-build-user@blackbaud.com> Co-authored-by: Steve Brush <steve.brush@blackbaud.com> Co-authored-by: Paula Hodgkins <77297281+blackbaud-paulah@users.noreply.github.com> Co-authored-by: John Lyons <John.Lyons@blackbaud.com> Co-authored-by: Braden Bisping <63625452+bradenbiz@users.noreply.github.com> * Release 5.0.0-beta.1 (#286) * Next > Adopt Angular CLI (#288) * Release 5.0.0-beta.2 (#289) * Build #skyux-forms-push-1198364695-34681: Added new baseline screenshots. [ci skip] * Remove circular references (#290) * Fix visual tests * Fix import paths * Update packages * Delete screenshots * Build #skyux-forms-push-1210649827-68966: Added new baseline screenshots. [ci skip] * Release 5.0.0-beta.3 (#291) * Next > Update peer dependencies (#292) * Build #skyux-forms-push-1221916356-27461: Added new baseline screenshots. [ci skip] * 5.0.0-beta.5 release; removed unnecessary dependency on @skyux/modals (#293) * Removed modals * 5.0.0-beta.5-release * Update CHANGELOG.md * baselines Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * Build #skyux-forms-push-1234569693-21840: Added new baseline screenshots. [ci skip] * Document sky-control-help class (#295) * Document sky-control-help class * Update dependencies as per error messages * package.lock * reset baselines Co-authored-by: John Lyons <John.Lyons@blackbaud.me> Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> * Build #skyux-forms-push-1258643898-83004: Added new baseline screenshots. [ci skip] * Workflow and package updates * Fix tests * Reset screenshot * Reset screenshot * Exact dependencies * @skyux/packages as prod dependency * Reset screenshots * Fix tests * Reset screenshots Co-authored-by: Alex Kingman <alex.kingman@blackbaud.me> Co-authored-by: Alex <alex.kingman@blackbaud.com> Co-authored-by: Paul Crowder <paul.crowder@blackbaud.com> Co-authored-by: Blackbaud Sky Build User <sky-build-user@blackbaud.com> Co-authored-by: Steve Brush <steve.brush@blackbaud.com> Co-authored-by: Paula Hodgkins <77297281+blackbaud-paulah@users.noreply.github.com> Co-authored-by: John Lyons <John.Lyons@blackbaud.com> Co-authored-by: Braden Bisping <63625452+bradenbiz@users.noreply.github.com> Co-authored-by: John Lyons <John.Lyons@blackbaud.me>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.