This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Expose Karma browser errors during skyux test; upgrade @angular-devkit/build-optimizer
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
changed the title
skyux test
Blackbaud-SteveBrush
changed the title
skyux testskyux test; upgrade @angular-devkit/build-optimizer
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 54
Lines 1634 1635 +1
Branches 252 252
=========================================
+ Hits 1634 1635 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| server.on('browser_error', () => { | ||
| logger.warn('Experienced a browser disconnect error. Karma will retry up to 3 times.'); | ||
| server.on('browser_error', (browser, error) => { | ||
| logger.warn(`[SKY UX Builder] Karma encountered a browser error: ${error.message}`); |
There was a problem hiding this comment.
Any benefit in spitting out the browser in this message too?
Blackbaud-BobbyEarl
approved these changes
Jul 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.