Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement blackberry.app.minimize #296

Closed
wants to merge 1 commit into from
Closed

Conversation

bryanhiggins
Copy link

@@ -211,6 +211,10 @@ module.exports = {
success(orientation);
},

minimize: function () {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a success parameter that you call

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the blackberry.application.exit() pattern.

Do you think it is wise to add a success callback when the application is going into a paused state?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that the logic around not having it for exit ? We've had issues in the past where there is no success because the whole event loop is waiting for it and the client JS is waiting as well.

@bryanhiggins
Copy link
Author

@jeffheifetz amended to call success on both minimize and exit

@haahmad
Copy link

haahmad commented Nov 27, 2012

Are you going to add any functional tests here?

@nukulb
Copy link

nukulb commented Nov 28, 2012

missing docs

@bryanhiggins
Copy link
Author

Added automated functional test

Docs are here: blackberry-webworks/WebWorks-API-Docs#236

@jeffheifetz
Copy link

Yay for more automated tests

@nukulb
Copy link

nukulb commented Nov 28, 2012

r+

@tracyli
Copy link

tracyli commented Nov 28, 2012

tested in 10.0.9.1500 with packager build http://ci0000003863287:8080/hudson/job/BB10-Webworks-Packager/120/ and framework build http://ci0000003863287:8080/hudson/job/BB10-Webworks-Framework-next-minimize/4/: app.minimize() works as expected; automated functional test got passed except for the following:
1)blackberry.inovke Register an invoke interrupter and expect the handler to NOT be triggered on invoke since it is not interruptable
TypeError: 'undefined' is not a function in local:///automatic/spec/blackberry.invoke.js', which is related to #293
2)blackberry.pim.calendar.findEvents can sort search results by location(asc) due to blackberry#372
3)white listing allowing access to web api on subdomains from external subdomains access apis from local->external->external cannot access whitelisted web api from previous page on second external page
Expected 'en-US' to be 'en-FR'
4)white listing web apis access from external server access apis from local->external->external cannot access whitelisted web api from previous page on second exteranl page
Expected 'en-US' to be 'en-FR'
5) blackberry.ui.toast can display toasts should display simple toast
expected: 'INFO: Failure in initializing PuppetMasterAgent Exiting...' to be 'true'

@jeffheifetz
Copy link

All of these issues except the toast automation are being reported for the next branch as well

@nukulb
Copy link

nukulb commented Nov 29, 2012

toast automation just sucks because puppet master sucks

@nukulb nukulb closed this Nov 29, 2012
@nukulb
Copy link

nukulb commented Nov 29, 2012

merged manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants