-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement blackberry.app.minimize #296
Conversation
@@ -211,6 +211,10 @@ module.exports = { | |||
success(orientation); | |||
}, | |||
|
|||
minimize: function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have a success parameter that you call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the blackberry.application.exit() pattern.
Do you think it is wise to add a success callback when the application is going into a paused state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was that the logic around not having it for exit ? We've had issues in the past where there is no success because the whole event loop is waiting for it and the client JS is waiting as well.
@jeffheifetz amended to call success on both minimize and exit |
Are you going to add any functional tests here? |
missing docs |
Added automated functional test Docs are here: blackberry-webworks/WebWorks-API-Docs#236 |
Yay for more automated tests |
r+ |
tested in 10.0.9.1500 with packager build http://ci0000003863287:8080/hudson/job/BB10-Webworks-Packager/120/ and framework build http://ci0000003863287:8080/hudson/job/BB10-Webworks-Framework-next-minimize/4/: app.minimize() works as expected; automated functional test got passed except for the following: |
All of these issues except the toast automation are being reported for the next branch as well |
toast automation just sucks because puppet master sucks |
merged manually |
Issue blackberry#396