Implemented QtStageWebView reload method #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void javaScriptWindowObjectCleared(); | ||
| void processMessage(Message* pMsg); | ||
| void resourceRequest(QNetworkRequest* request); | ||
| void resourceReply(QNetworkReply* reply); | ||
| void resourceRequest(QNetworkRequest* request); |
There was a problem hiding this comment.
I can't tell if I'm missing a subtle difference (or if this is a bug with the diff)...are resourceRequest and resourceReply defined twice?
There was a problem hiding this comment.
I was actually fixing the indentation and code formatting, the diff makes it look weird since it's removing and adding the same line.
|
resourceReply actually means "resourceResponse" |
ghost
closed this
|
Ah, those are tabbled? I removed a lot of tabs in other places, i'll go fix them |
…to load on a slow connection
|
Added some more changes, should be good to pull now. |
|
looks OK for me, approved |
ghost
closed this
ericpearson
added a commit
that referenced
this pull request
Aug 8, 2011
Implemented QtStageWebView reload method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.