This repository has been archived by the owner on Sep 4, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or invoked callback. issue #440
bug fixes for invoke
fixes issue #383
…dated the userAgent for PlayBook
npapi work
final implementation of npapi plugin
It was still being installed via `npm install` (in package.json), but there is no use of it anywhere in the code.
This commit: 7b5e6d5 ..seems to be in order, but for some reason it is not being applied, and the older version of jasmine is still checked out.. which is odd.
Cleaned up a few things- mostly just adding periods at the end of points or sentences (and other small things).
It just felt a bit better to "beef up" the sentence, and also move it.
If there is a `theme` query string parameter set in the currently enabled app's URL, then it is picked up on boot and set appropriately. Example: http://127.0.0.1:80/app.html?theme=light
Note: Since I refactored a small bit, the actual fix was in the `.sort` comparison function.
It is also a very vague attribute, and it was only around (as I recall) for previous platform(s).
It was only around (as I recall) for previous platform(s).
An example of UI text would be anything in the left and right panels, and top (if it is being used). This also gives a better user experience, because you can not accidentally click and select, which highlights the UI visually. This can be annoying, since there is no need (ever) to select UI text.
Ex: the user agent string.
Added eula support
fixes issue #473
This would prevent the buttons from working.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.