Version 0.9.13 #710
Version 0.9.13 #710
Conversation
Fixed spelling mistake :(
When it was initially created (i.e. re-written) this was an oversight that was made (as it seemed quite solid). This is not true. Stuff can go bad (especially if server errors out continually)... so, let's fix it! There are two ways errors can happen. 1. Synchronously thrown errors when initializing a client request. Example: passing an invalid URI (i.e. a local '/foo/bar' url) will cause an exception to be thrown (which could possibly crash the app). 2. Errors during the (async) request itself (notified via error event). Example: Passing in a URL that fails during DNS lookup will raise an `error` on the client request object (ex: http://googleeee.com). Note: Since errors were already captured by `request` and passed into the callback (as you can see), the XHR proxy already gracefully handled errors, but that was never taken advantage of when using `request.pipe`. This cleans that up so it always look for an error object and responds with a 500 (and error message), if so.
This was a duplicate call and not needed.
This was done to remove any console logs that show up before Ripple is fully booted and can be confusing to the developer.
This (presumably) adds support for the rest of the verbs, which were left out when the proxy was re-written :-( (there definitely could have been more testing in place for this, alas, resources..). This fixes GitHub issue: https://github.com/blackberry/Ripple-UI/issues/693
It is also an HTTP verb that should be supported by CORS (in the xhr proxy). I hastily pushed commit 8462f02 and missed this.
The bodyParser middleware would parse the JSON properly, however the `form` option in `request` was being used, and it was sent as a 'application/x-www-form-urlencoded' request. Instead it should be stringified and set to the `request`'s `body` option. This fixes another issue pointed out in: https://github.com/blackberry/Ripple-UI/issues/693
Added the Q10 device Update the Colt (DevAlpha) to the Z10 Removed Cold images Update manufacturer to BlackBerry from Research In Motion on all BlackBerry devices
Merged pull request from @maxme Fixed failing tests for changes made update the creation of a new Blob to include type setting
|
Looks good to me. +1. :-) Yay, new device skins! |
|
Hi, when can we expect to upload ripple extension to 0.9.13 directly from chrome://extensions/, currently there is only 0.9.12 available ?.. |
|
The plan is to release it to the chrome store and to the blackberry Dan Silivestru On 2013-02-04, at 17:27, szuzul notifications@github.com wrote: Hi, when can we expect to upload ripple extension to 0.9.13 directly from — |
|
That's cool, thanks... I'm also having xhr_proxy error in options and get request in my backbone app. |
|
Can you share some code with us? I would suggest you open a new issue with Thanks, Dan Silivestru On 2013-02-04, at 19:09, szuzul notifications@github.com wrote: That's cool, thanks... I'm also having xhr_proxy error in options and get — |
|
It isn't xhr_proxy error as i can see now. it is something in relation with time out response in case of ripple and require.js... I'll open new issue. |
No description provided.