Version 0.9.13 #710

Merged
merged 13 commits into from Feb 4, 2013

Conversation

Projects
None yet
3 participants
Contributor

dansilivestru commented Jan 31, 2013

No description provided.

dansilivestru and others added some commits Jan 14, 2013

Update doc/CHANGELOG.md
Fixed spelling mistake :(
The cross origin XHR proxy does not entirely handle errors (gracefully).
When it was initially created (i.e. re-written) this was an oversight
that was made (as it seemed quite solid). This is not true. Stuff can go
bad (especially if server errors out continually)... so, let's fix it!

There are two ways errors can happen.

1. Synchronously thrown errors when initializing a client request.

Example: passing an invalid URI (i.e. a local '/foo/bar' url) will
cause an exception to be thrown (which could possibly crash the app).

2. Errors during the (async) request itself (notified via error event).

Example: Passing in a URL that fails during DNS lookup will raise an
`error` on the client request object (ex: http://googleeee.com).

Note: Since errors were already captured by `request` and passed
into the callback (as you can see), the XHR proxy already gracefully
handled errors, but that was never taken advantage of when using
`request.pipe`. This cleans that up so it always look for an error
object and responds with a 500 (and error message), if so.
Removed call to widgetConfig.initialize
This was a duplicate call and not needed.
Added call to console.clear after boot
This was done to remove any console logs that show up
before Ripple is fully booted and can be confusing to the
developer.
There is lack of CORS (XHR proxy) support for certain HTTP verbs.
This (presumably) adds support for the rest of the verbs, which were
left out when the proxy was re-written :-( (there definitely could have
been more testing in place for this, alas, resources..).

This fixes GitHub issue:

https://github.com/blackberry/Ripple-UI/issues/693
The OPTIONS verb was left out in the previous (XHR proxy fix) commit.
It is also an HTTP verb that should be supported by CORS (in the xhr
proxy).

I hastily pushed commit 8462f02
and missed this.
Cross origin (JSON based) XHR proxy requests are not forwarded properly.
The bodyParser middleware would parse the JSON properly, however the
`form` option in `request` was being used, and it was sent as a
'application/x-www-form-urlencoded' request. Instead it should be
stringified and set to the `request`'s `body` option.

This fixes another issue pointed out in:

https://github.com/blackberry/Ripple-UI/issues/693
Added new BB10 device, update manufacturer
Added the Q10 device
Update the Colt (DevAlpha) to the Z10
Removed Cold images
Update manufacturer to BlackBerry from Research In Motion on all
BlackBerry devices
Merged deprecated blobWriter fix and fixed tests
Merged pull request from @maxme
Fixed failing tests for changes made
update the creation of a new Blob to include type setting
Contributor

dansilivestru commented on ab19cc4 Jan 31, 2013

And by BlobWriter... I mean BlobBuilder

Contributor

brentlintner commented Jan 31, 2013

Looks good to me. +1. :-)

Yay, new device skins!

@dansilivestru dansilivestru merged commit e238dd5 into master Feb 4, 2013

@brentlintner brentlintner referenced this pull request Feb 4, 2013

Closed

Device.proxy #711

szuzul commented Feb 4, 2013

Hi, when can we expect to upload ripple extension to 0.9.13 directly from chrome://extensions/, currently there is only 0.9.12 available ?..

Contributor

dansilivestru commented Feb 4, 2013

The plan is to release it to the chrome store and to the blackberry
developer site tomorrow.

Dan Silivestru
+1 (519)-589-3624

On 2013-02-04, at 17:27, szuzul notifications@github.com wrote:

Hi, when can we expect to upload ripple extension to 0.9.13 directly from
chrome://extensions/, currently there is only 0.9.12 available ?..


Reply to this email directly or view it on
GitHubhttps://github.com/blackberry/Ripple-UI/pull/710#issuecomment-13103460.

szuzul commented Feb 5, 2013

That's cool, thanks... I'm also having xhr_proxy error in options and get request in my backbone app.

Contributor

dansilivestru commented Feb 5, 2013

Can you share some code with us? I would suggest you open a new issue with
code sample and steps to reproduce.

Thanks,

Dan Silivestru
+1 (519)-589-3624

On 2013-02-04, at 19:09, szuzul notifications@github.com wrote:

That's cool, thanks... I'm also having xhr_proxy error in options and get
request in my backbone app.


Reply to this email directly or view it on
GitHubhttps://github.com/blackberry/Ripple-UI/pull/710#issuecomment-13107799.

szuzul commented Feb 7, 2013

It isn't xhr_proxy error as i can see now. it is something in relation with time out response in case of ripple and require.js... I'll open new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment