Context menu shows up on scrolling #728

Merged
merged 3 commits into from Feb 25, 2013

Projects

None yet

3 participants

@dirkjanm
Contributor

Context menu

  • Fixes context menu showing up when scrolling on image list and image grid (temporary fix until move
    to native webworks is complete)
  • Adds function bb.getCurScreen to get the current screen element
  • Fixes some things mentioned in #370
@dirkjanm dirkjanm Context menu fixes
- Fixes context menu showing up when scrolling (temporary fix until move
to native webworks is complete)
- Adds function bb.getCurScreen to get the current screen element
- Adds property bb-data-useid for menus to set an ID on the element
which makes it easier to retrieve it later
01cfdc5
Contributor

This should do.

dirkjanm added some commits Feb 25, 2013
@dirkjanm dirkjanm Changed getCurScreen to querySelector b16dda5
@dirkjanm dirkjanm Added imagelist support and removed screen menu changes
- Context menu now also fixed on image lists
- Screen menu changes reversed
2031d26
Contributor

Fixed it for image lists too (tested with Samples on Dev Alpha).
Reversed the screen menu changes mentioned earlier

@tneil tneil merged commit da21faa into blackberry:master Feb 25, 2013
kraaly53 commented Mar 3, 2013

I have a Scroll Panel with a Image List in my application, I have a Context Menu attached to the list, I just updated my application to the newest bbui and now the context menu no longer opens. I am using the latest bbui and I get the same result in the 10.0.10.261 Simulator that I do in Ripple (0.9.13). I get the following error when I perform a long hold to get context menu: "Uncaught TypeError: Cannot read property 'scrollTop' of undefined". I added a context menu to the list in the scroll panel part of the bbui samples application and I get the same error when I try it in the simulator and ripple. When I open the context menu part of the samples, the context menu opens without issue.

Untitled-3

Contributor
dirkjanm commented Mar 3, 2013

I created issue #738 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment