Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointer from some HalLink methods if created from URI #15

Closed
ghost opened this issue Jun 16, 2016 · 5 comments
Closed

NullPointer from some HalLink methods if created from URI #15

ghost opened this issue Jun 16, 2016 · 5 comments
Assignees
@nrktkt
Labels
bug help wanted

Comments

@ghost
Copy link

ghost commented Jun 16, 2016

When a HalLink is created from a URI it uses a Boolean member variable templated to track this by setting it to null

When later calling isTemplated or something that calls it (getHrefAsUri or getHrefAsTemplate) a null pointer is thrown as isTemplated's signature tries to return a primitive boolean
@nrktkt nrktkt self-assigned this Jun 16, 2016
@nrktkt nrktkt mentioned this issue Jun 16, 2016
Closed
@nrktkt
Copy link
Member

nrktkt commented Jun 16, 2016

That's no good! Nice catch. I'll patch that shortly.

@ghost
Copy link
Author

ghost commented Jun 16, 2016

Ace! Thanks for the swift response

nrktkt added a commit that referenced this issue Jun 16, 2016
@nrktkt
Fix #15
b6a7b8c 
Only isTemplated is optional for now, update of remaining fields and more extensive optional jackson testing pending.
nrktkt added a commit that referenced this issue Jun 16, 2016
@nrktkt
Fix #15
a4cad98 
Only isTemplated is optional for now, update of remaining fields and more extensive optional jackson testing pending.
@nrktkt nrktkt mentioned this issue Jun 16, 2016
Merged
nrktkt added a commit that referenced this issue Jun 17, 2016
@nrktkt
Fix #15
952db53
nrktkt added a commit that referenced this issue Jun 17, 2016
@nrktkt
Fix #15
3a46c58
@nrktkt nrktkt closed this as completed in f180ce9 Jun 17, 2016
nrktkt added a commit that referenced this issue Jun 17, 2016
@nrktkt
Merge pull request #17 from blackdoor/bugfix/#15_null-ptr
4b37a4a 
Fix #15
@nrktkt
Copy link
Member

nrktkt commented Jun 17, 2016

@at-alexb as a follow up, can you confirm that the new version (v1r3t2) fixes the issue for you?

@ghost
Copy link
Author

ghost commented Jun 17, 2016

Yes, confirmed issue fixed in v1r3t2

@nrktkt
Copy link
Member

nrktkt commented Jun 17, 2016

@at-alexb great! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrktkt nrktkt

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nrktkt