Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented retest feature #114

Open
wants to merge 2 commits into
base: github-dev
Choose a base branch
from

Conversation

thejohnbrown
Copy link
Contributor

I have implemented a retest feature into Writehat which allows you to record and present the results from any vulnerability retesting that might occur for that engagement.

The following things have been added:

  • A status option toggle has been added for each finding (open, fixed, not fixed, risk accepted, etc.)
  • A retest field has been added to each finding for recording results of the retest
  • A toggle has been added to the FIndings component which allows you to enable or disable the status for a particular finding group
  • A new component has been added for summarising the retest results:

image

@TMDeal
Copy link
Collaborator

TMDeal commented Apr 25, 2024

could you see about resolving the merge conflicts that this branch has with the github-dev branch?

@thejohnbrown
Copy link
Contributor Author

Is there anything else required to get this merged?

Copy link
Collaborator

@TMDeal TMDeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML report does not seem to render anymore, and just gives a 500 error. Seems to be about mismatching if/endif statements.

image

Also, for the HTML templates for FindingList components, those have changed quite a bit from master to github-dev. Due to some pagedjs shenanigans, I had to drastically change how this template was structured, and use pagedjs hooks to further accomplish those goals. The relevant code for the pagedjs hooks can be found in paged-overrides.js. So for each section in the finding table, it needs to follow this pattern or it will not render properly.

<div class='finding-content'>
    <div class='finding-content-header category'>
        Category
    </div>
    <div class='finding-content-body' style='font-weight: bold'>
        {{ finding.categoryFull }}
    </div>
</div>

category can be replaced with any other name you need, like retest for example. The changes are pretty significant, so if you need any assistance with the changes made, please let me know

Once those issues are resolved, this should be good to go.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component should additionally be able to filter by finding group, like what we do in FindingsList.py. That way we dont always have to show the status of every finding group all the time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This css addition is no longer necessary, since this info should now just be put in the HTML template directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants