Currency field not always required #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankienicoletti
suggested changes
Jun 26, 2018
adjustments.go
Outdated
| @@ -49,7 +49,7 @@ func (a Adjustment) MarshalXML(e *xml.Encoder, start xml.StartElement) error { | |||
| ProductCode string `xml:"product_code,omitempty"` | |||
| UnitAmountInCents int `xml:"unit_amount_in_cents"` | |||
| Quantity int `xml:"quantity,omitempty"` | |||
| Currency string `xml:"currency"` | |||
| Currency string `xml:"currency,omitempty"` | |||
There was a problem hiding this comment.
Can you add an in-line comment here that says something like // Should only be omitted in purchase calls? This field is still required to create an adjustment and I don't want it to look optional.
nelz9999
force-pushed
the
adjustment-currency
branch
from
99c19e1
to
7b7737d
Compare
|
@katenicoletti Comment added. (Tho, somewhat generic. I hope that's okay.) |
frankienicoletti
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the existing
Adjustmentobject for use against thePurchasesAPI, was getting an error with the following text:The provided XML was invalid. Adjustments cannot contain a child currency tag.This just sets the currency element as
omitempty, and tidies up tests that hard-coded the element.