Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency field not always required #62

Merged
merged 2 commits into from Jun 26, 2018
Merged

Currency field not always required #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81b76f3
Currency field not always required
Jun 25, 2018
7b7737d
comment per PR request
Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion adjustments.go
View file
Open in desktop
Expand Up @@ -49,7 +49,7 @@ func (a Adjustment) MarshalXML(e *xml.Encoder, start xml.StartElement) error {
ProductCode string `xml:"product_code,omitempty"`
UnitAmountInCents int `xml:"unit_amount_in_cents"`
Quantity int `xml:"quantity,omitempty"`
Currency string `xml:"currency"`
Currency string `xml:"currency,omitempty"` // Required for some operations
TaxCode string `xml:"tax_code,omitempty"`
TaxExempt NullBool `xml:"tax_exempt,omitempty"`
StartDate NullTime `xml:"start_date,omitempty"`
Expand Down
2 changes: 1 addition & 1 deletion adjustments_test.go
View file
Open in desktop
Expand Up @@ -25,7 +25,7 @@ func TestAdjustments_Encoding(t *testing.T) {
expected string
}{
// Unit amount in cents and currency are required fields. They should always be present.
{v: recurly.Adjustment{}, expected: "<adjustment><unit_amount_in_cents>0</unit_amount_in_cents><currency></currency></adjustment>"},
{v: recurly.Adjustment{}, expected: "<adjustment><unit_amount_in_cents>0</unit_amount_in_cents></adjustment>"},
{v: recurly.Adjustment{UnitAmountInCents: 2000, Currency: "USD"}, expected: "<adjustment><unit_amount_in_cents>2000</unit_amount_in_cents><currency>USD</currency></adjustment>"},
{v: recurly.Adjustment{Description: "Charge for extra bandwidth", ProductCode: "bandwidth", UnitAmountInCents: 2000, Currency: "USD"}, expected: "<adjustment><description>Charge for extra bandwidth</description><product_code>bandwidth</product_code><unit_amount_in_cents>2000</unit_amount_in_cents><currency>USD</currency></adjustment>"},
{v: recurly.Adjustment{Quantity: 1, UnitAmountInCents: 2000, Currency: "CAD"}, expected: "<adjustment><unit_amount_in_cents>2000</unit_amount_in_cents><quantity>1</quantity><currency>CAD</currency></adjustment>"},
Expand Down
2 changes: 1 addition & 1 deletion purchases_test.go
View file
Open in desktop
Expand Up @@ -74,7 +74,7 @@ func TestPurchases_Purchase_Encoding(t *testing.T) {
"<shipping_addresses><shipping_address><first_name>Lon</first_name><last_name>Doner</last_name><nickname>Home</nickname><address1>221B Baker St.</address1><address2></address2><city>London</city><state></state><zip>W1K 6AH</zip><country>GB</country></shipping_address></shipping_addresses>" +
"</account>" +
"<adjustments><adjustment>" +
"<description>Description of this adjustment</description><product_code>4549449c-5870-4845-b672-1d07f15e87dd</product_code><unit_amount_in_cents>1000</unit_amount_in_cents><quantity>1</quantity><currency></currency>" +
"<description>Description of this adjustment</description><product_code>4549449c-5870-4845-b672-1d07f15e87dd</product_code><unit_amount_in_cents>1000</unit_amount_in_cents><quantity>1</quantity>" +
// TODO: RevenueScheduleType not yet modeled
// "<revenue_schedule_type>at_invoice</revenue_schedule_type>"+
"</adjustment></adjustments>" +
Expand Down