Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #47 Add support for image or video file path #50

Closed
wants to merge 1 commit into from

Conversation

DanialV
Copy link

@DanialV DanialV commented May 17, 2020

Hi, I solved this problem for the local project I add another argument file in the story view widget and it works fine in my local project so I decided to send a pull request please check my work thanks.

@blackmann
Copy link
Owner

Great work @DanialV . Sorry for the late response. I've looked at your commit. I think the API becomes bloated if we include an explicit parameter file. Instead what we can do is use protocols for the url. That is, specifying url as file://mnt/ex0/downloads/video.mp4 for instance, indicates a file and loads from that directory.

What do you think?

@umaqs
Copy link

umaqs commented Nov 14, 2020

I am also interested in this. @DanialV I think the API would look better with named constructors like following:

StoryItem.pageLocalImage() 
StoryItem.pageNetworkImage()
StoryItem.pageLocalVideo()
StoryItem.pageNetworkVideo()

@blackmann
Copy link
Owner

Closing for inactivity

@blackmann blackmann closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants