fix: fix dataview inline fields render breaks icon shortcodes #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace find-and-replace in innerHTML with TreeWalker and text node manipulation fix blacksmithgu#974
aidenlx
added a commit
to aidenlx/obsidian-icon-shortcodes
that referenced
this pull request
May 17, 2022
update text node replace method; improve handling of async processor works when blacksmithgu/obsidian-dataview#1098 is merged
blacksmithgu
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace find-and-replace in innerHTML with TreeWalker and text node manipulation
see also: #974 (comment)
fix #974