Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes #95

Merged
merged 1 commit into from
Aug 17, 2021
Merged

small changes #95

merged 1 commit into from
Aug 17, 2021

Conversation

luckman212
Copy link
Collaborator

n.b. I switched from tabs to spaces since last time, so the changes below look larger than they actually are. Append ?w=1 param to the diff url to ignore that whitespace... e.g. d35323d

small update

  • add fix_flags.sh helper to remove quarantine and set +x bit instead of repeating that in every script action
  • remove dependency on $(arch) tests -- refer instead to universal binary. @blacs30 build with:
lipo -create -output bitwarden-alfred-workflow bitwarden-alfred-workflow-amd64 bitwarden-alfred-workflow-arm64
  • clean up case syntax, remove unnecessary opening (s
  • switch to $UID instead of forking $(id -u) (faster)
  • added small usage help text
  • add --setenv command line option to export the env vars for debugging

- add `fix_flags.sh` helper to remove quarantine and set +x bit instead of repeating that in every script action
- remove dependency on $(arch) test -- refer to universal binary:
```
lipo -create -output bitwarden-alfred-workflow bitwarden-alfred-workflow-amd64 bitwarden-alfred-workflow-arm64
```
- clean up case syntax, remove unnecessary opening `(`s
- switch to $UID instead of forking `$(id -u)` (faster)
- added small usage help text
- add `--setenv` command line option to export the env vars for debugging
Copy link
Owner

@blacs30 blacs30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions. Thanks a lot.

@blacs30 blacs30 merged commit b34ffef into blacs30:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants