Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing null to value attribute of input component #60

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Allow passing null to value attribute of input component #60

merged 2 commits into from
Sep 9, 2020

Conversation

mvdnbrk
Copy link
Contributor

@mvdnbrk mvdnbrk commented Sep 8, 2020 •
edited

Resolves #58 .
Related #59.

@mvdnbrk mvdnbrk changed the title Allow passing null for value attribute Allow passing null to value attribute of input component Sep 8, 2020
@driesvints
Copy link
Member

We'll also need to update all other input components. Can you also do that here?

@mvdnbrk
Copy link
Contributor Author

mvdnbrk commented Sep 9, 2020

👍

@driesvints driesvints merged commit 7cedcda into blade-ui-kit:0.x Sep 9, 2020
@driesvints
Copy link
Member

Cool, thanks for the PR!

@mvdnbrk mvdnbrk deleted the fix-input-value-null branch September 9, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input component should accept null for the value attribute
2 participants
@mvdnbrk @driesvints