Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External assets of mods not being supported #34

Closed
CUexter opened this issue Apr 15, 2024 · 9 comments
Closed

External assets of mods not being supported #34

CUexter opened this issue Apr 15, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@CUexter
Copy link

CUexter commented Apr 15, 2024

I tried to install 2 mods but failed. It all involves accessing file that are not lua files. Maybe allow us to use external storage ?

Jojo's Tarot Cards
JoJo's Tarots

@blake502 blake502 added enhancement New feature or request help wanted Extra attention is needed labels Apr 15, 2024
@blake502
Copy link
Owner

Mods are out-of-scope for this project. I'm not even sure if it's possible, given this. Nativefs might not even support Android.

I'm open to exploring this myself at a later point, but there are some more important things I'd like to tackle with the project first.

@CUexter
Copy link
Author

CUexter commented Apr 15, 2024

i want to know if external storage patch support this but i will try maybe on thursday.

@blake502
Copy link
Owner

I'd love to be wrong about this-- But I think that's an oversimplification of how it works.

I haven't looked in to this, mind you, so take this with a grain of salt.. I imagine full mod support would require a patched version of Steamodded that loads all the files from a location that would play nicely with Android.

If you're able to work this out, please let me know what you find. I'm open to making the necessary changes, or merging a PR.

@eszoke
Copy link

eszoke commented Apr 15, 2024

While it doesn't solve the issue of installing mods on the fly on an existing mobile install, and not sure how LUA mods would work.

But any straight asset replacement mods can still be used by just directly modifying the files in balatro.exe (can change it to .zip) and using that modded exe with the APK/IPA maker.

Got a couple of card and enhancement texture replacements working on both Android and iOS.

@blake502
Copy link
Owner

So you're saying that the assets can just be packed into the exe, and do not need to be in the mods folder?

If that's the case, I can have Balatro Mobile Maker detect mods during the build process, and offer to automatically pack the assets with the mobile build.

@blake502 blake502 self-assigned this Apr 20, 2024
@CUexter
Copy link
Author

CUexter commented Apr 20, 2024 via email

@CUexter
Copy link
Author

CUexter commented Apr 21, 2024

i am sorry, but i have fixed the problem, the problem being that mods that have a folder named Assets need to be named assets in ios and android.

which is kinda strange because on linux it works fine as well.

so perhaps the most easy way is to turn any uppercase named folder to lowercase folder

@CUexter
Copy link
Author

CUexter commented Apr 21, 2024

if you want you can close the issue

@blake502
Copy link
Owner

i am sorry, but i have fixed the problem, the problem being that mods that have a folder named Assets need to be named assets in ios and android.

which is kinda strange because on linux it works fine as well.

so perhaps the most easy way is to turn any uppercase named folder to lowercase folder

Thanks for this info! I'll keep it in mind if we decide to implement official mod support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants