-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract MQTT from communication and make mqtt optional #4462
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
1c516da
to
c98da57
Compare
bd8d75f
to
9054542
Compare
@@ -39,6 +39,8 @@ It is not recommended to copy this full configuration file. Only specify values | |||
|
|||
```yaml | |||
mqtt: | |||
# Optional: Enable mqtt server (default: shown below) | |||
enabled: True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since for HA users it's mandatory to enable mqtt AND set the host, user and passwords, I would recommend having MQTT disabled by default.
At least Frigate would work without having to set anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean, with this if nothing is set frigate should still run just fine it'll just have errors in the logs.
And if I set it to disabled by default then that would break every existing users setup by default. even if we had a huge font note in the changelog, there'd still be plenty of users who made issues because they didn't read the changelog and their automations stopped working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if I set it to disabled by default then that would break every existing users setup by default. even if we had a huge font note in the changelog, there'd still be plenty of users who made issues because they didn't read the changelog and their automations stopped working.
I thought breaking changes were not much of a problem as long as properly documented, they seem to happen in almost every major 0.x releases anyway.
But it's up to you. It was just a suggestion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're definitely not wrong but trying to move in the direction of less breaking changes.
No description provided.