Migrate away from deprecated np.float #5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is an alias for the python float type, and got deprecated in 1.20 and was removed in 1.24. The rest of the project already uses float32 (single), so I believe this is also correct here, as opposed to float64 (double).
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
blakeblackshear
approved these changes
Apr 16, 2023
mew1033
pushed a commit
to mew1033/frigate
that referenced
this pull request
Apr 19, 2023
It is an alias for the python float type, and got deprecated in 1.20 and was removed in 1.24. The rest of the project already uses float32 (single), so I believe this is also correct here, as opposed to float64 (double).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an alias for the python float type, and got deprecated in 1.20 and was removed in 1.24. The rest of the project already uses float32 (single), so I believe this is also correct here, as opposed to float64 (double).
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations