Feature: automatic camera resolution configuration

[skrashevich]

No description provided.

[netlify]

✅ Deploy Preview for frigate-docs canceled.

Name	Link
🔨 Latest commit	59e7ec1
🔍 Latest deploy log	https://app.netlify.com/sites/frigate-docs/deploys/649909e213aeb10008e933d2

[NickM-27]

I believe the fps should be set to 5 even if the source stream is higher, this is by design as the default recommended fps for most users. Not all users actually set their cameras to this though.

[skrashevich]

I believe the fps should be set to 5 even if the source stream is higher, this is by design as the default recommended fps for most users

this PR don't touch fps setting

[NickM-27]

Gotcha, my bad

[NickM-27]

Also just a reminder once things are decided the configuration/index docs should be updated. In this case the getting started guide should also be updated to remove the recommendation to set the width / height

[skrashevich]

And i don’t have idea what’s best to do if several streams are available by URL. To take the first, or the best?

[NickM-27]

I'm not familiar with cameras that have multiple streams available on the exact same URL. In that case maybe log a warning that auto detection found multiple resolutions. I think it's safer to pick the lowest quality stream to ensure cpu isn't taxed too much

[blakeblackshear]

Earlier versions did autodetect the resolution like this. I remember there being enough issues with the reliability of cv2.VideoCapture that I decided it was more hassle than it was worth. It's worth trying again.

[skrashevich]

Earlier versions did autodetect the resolution like this. I remember there being enough issues with the reliability of cv2.VideoCapture that I decided it was more hassle than it was worth. It's worth trying again.

I can modify get_video_properties function to use ffprobe as fallback, if cv2 will fail to determine stream

[NickM-27]

I can modify get_video_properties function to use ffprobe as fallback, if cv2 will fail to determine stream

this is what I am doing for the get_duration part as well since I found some segment that cv2 could not get the duration of

[NickM-27]

I think ffprobe should be used to get width / height when cv2 fails. also a couple other docs changes

[NickM-27]

I still think the top level "minimal config" should just have the detect config removed.

and regardless, the specific detect config needs to e updated.

frigate/docs/docs/configuration/index.md

Lines 195 to 199 in 7c1568f

	detect:
	# Optional: width of the frame for the input with the detect role (default: shown below)
	width: 1280
	# Optional: height of the frame for the input with the detect role (default: shown below)
	height: 720

[skrashevich]

but this lines in the 'Full configuration reference' part

[NickM-27]

The first part is specifically in the Minimal Configuration part and the width / height is not part of a minimal configuration

The second part needs to be updated. The defaults are no longer 1280 x 720 the default is to auto detect with a fallback of 1280x720.

[skrashevich]

No. on your screenshot lines 3-24. But in this thread we are talking about lines 195-199 (see first message)

[NickM-27]

Gotcha, but for lines 195-199 they need to be updated because

The defaults are no longer 1280 x 720, the default is now to auto detect with a fallback of 1280x720.

[skrashevich]

Gotcha, but for lines 195-199 they need to be updated because

I think, here only needs to change the wording of the comment, about autoconfiguration and fallback. And I'm definitely not the best man for that :)

[skrashevich]

I think ffprobe should be used to get width / height when cv2 fails. also a couple other docs changes

At the moment, this PR does not affect the get_video_properties function

[NickM-27]

let's simplify this code and move this logic outside of the try / except and have the except clause set stream_info to {"width": 0, "height": 0}

that way the values are only set to the config in one place

[skrashevich]

Do you mean that I should manually generate an exception in get_video_properties if one of dimensions is zero?

[NickM-27]

No, this is what I am suggesting

                        try:
                            stream_info = get_video_properties(input.path)
                        except Exception:
                            stream_info = {"width": 0, "height": 0}

                        if stream_info["width"] == 0 or stream_info["height"] == 0:
                            logger.warn(
                                f"Error detecting stream resolution automatically for {input.path} Applying default values."
                            )

                        camera_config.detect.width = (
                           stream_info["width"]
                            if stream_info["width"] > 0
                            else DEFAULT_DETECT_DIMENSIONS["width"]
                        )
                        camera_config.detect.height = (
                            stream_info["height"]
                            if stream_info["height"] > 0
                            else DEFAULT_DETECT_DIMENSIONS["height"]
                        )

[blakeblackshear]

Suggested change

	stream_info = {"width": 0, "height": 0}
	try:
	stream_info = get_video_properties(input.path)
	except Exception:
	logger.warn(
	f"Error detecting stream resolution automatically for {input.path} Applying default values."
	)
	stream_info = {"width": 0, "height": 0}
	camera_config.detect.width = (
	stream_info["width"]
	if stream_info.get("width")
	else DEFAULT_DETECT_DIMENSIONS["width"]
	)
	camera_config.detect.height = (
	stream_info["height"]
	if stream_info.get("height")
	else DEFAULT_DETECT_DIMENSIONS["height"]
	)
	stream_info = {"width": DEFAULT_DETECT_DIMENSIONS["width"], "height": DEFAULT_DETECT_DIMENSIONS["height"]}
	try:
	stream_info = get_video_properties(input.path)
	except Exception:
	logger.warn(
	f"Error detecting stream resolution automatically for {input.path} Applying default values."
	)
	camera_config.detect.width = stream_info["width"]
	camera_config.detect.height = stream_info["height"]

[skrashevich]

you will get width and height values from previous loop iteration, if get_video_properties() fails

[blakeblackshear]

Maybe I'm missing something. I am initializing stream_info with the defaults before calling get_video_properties, so I don't see how the previous loop could carry over.