Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: automatic camera resolution configuration #6810
Feature: automatic camera resolution configuration #6810
Changes from 10 commits
535f710
63cd8e5
a53fc32
5ca3035
a1aed04
838f246
2fff932
cbb3911
747006c
6d202c6
31ead3e
4681e1f
b90eba9
990b6dd
745a6d1
76886ec
2682aa9
59e7ec1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think the top level "minimal config" should just have the detect config removed.
and regardless, the specific detect config needs to e updated.
frigate/docs/docs/configuration/index.md
Lines 195 to 199 in 7c1568f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this lines in the 'Full configuration reference' part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first part is specifically in the
Minimal Configuration
part and the width / height is not part of a minimal configurationThe second part needs to be updated. The defaults are no longer 1280 x 720 the default is to auto detect with a fallback of 1280x720.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. on your screenshot lines 3-24. But in this thread we are talking about lines 195-199 (see first message)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, but for lines 195-199 they need to be updated because
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, here only needs to change the wording of the comment, about autoconfiguration and fallback. And I'm definitely not the best man for that :)