Set default min score for attributes labels to 0.7 #8001
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
frigate/config.py
Outdated
| for attribute in ALL_ATTRIBUTE_LABELS: | ||
| if ( | ||
| not config.objects.filters | ||
| or config.objects.filters.get(attribute, FilterConfig()).min_score == 0.5 |
There was a problem hiding this comment.
Won't this overwrite all their filters if they had specified a min_score of 0.5?
There was a problem hiding this comment.
yeah, if the filter was manually set to 0.5 it would get overwritten. The issue I am trying to figure out how to handle is the case where a user sets min_area for example but the default min_score shouldn't be affected by that and I think we'd still want it to be 0.7 in that case
There was a problem hiding this comment.
So I'm basically assuming users won't want to set the min_score for an attribute to 0.5, there definitely may be a better approach but I can't find a good way to have the default_factory for a field be able to access the key from the dict for example. Because if we knew the label for that particular FilterConfig then the min_score could be automatic
NickM-27
force-pushed
the
attribute-min-score
branch
from
dc603c2
to
bf4cb25
Compare
No description provided.