Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to no-case@2.3.2 #45

Merged
merged 1 commit into from Feb 25, 2018
Merged

upgrade to no-case@2.3.2 #45

merged 1 commit into from Feb 25, 2018

Conversation

syntactic-salt
Copy link
Contributor

This pull request addresses issue #44.

All tests remain passing after the update.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fdb7215 on syntactic-salt:upgrade-no-case into c61014e on blakeembrey:master.

@syntactic-salt
Copy link
Contributor Author

@blakeembrey I noticed pull request #41 is trying to resolve the same security vulnerability as I am here. #41 has been sitting around for a couple months. Is this project dead?

@blakeembrey
Copy link
Owner

Dead seems a bit over the top, it just doesn't really require updates and I have things I needed to be doing instead of OSS. Anyone installing the library would have been getting that latest no-case release either way, so I wasn't in a rush to update. I'll merge #41 now, thanks for the PR!

@blakeembrey
Copy link
Owner

Oh, the reason I didn't merge his immediately was because he changed the package.json version. If I needed to go in a fix stuff or back and forth when I really didn't have time, I just skipped it.

@blakeembrey blakeembrey merged commit c358398 into blakeembrey:master Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants