Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package versions #408

Merged
merged 2 commits into from Oct 7, 2022
Merged

Update package versions #408

merged 2 commits into from Oct 7, 2022

Conversation

danny-may
Copy link
Contributor

No description provided.

@danny-may danny-may added the dependencies Pull requests that update a dependency file label Sep 29, 2022
@danny-may danny-may self-assigned this Sep 29, 2022
@danny-may
Copy link
Contributor Author

Seems typescript 4.8.4 isnt supported by yarn berry yet, waiting until their fix is deployed before this PR can go through
yarnpkg/berry#4915

@HunteRoi
Copy link
Member

HunteRoi commented Sep 30, 2022

I saw you updated mocha to 10.0.0. Aren't there breaking changes ? I don't see any update in test files... 🤔

@danny-may
Copy link
Contributor Author

Mocha was updated in the last dependency update I did, this is just the update to the typings

@HunteRoi
Copy link
Member

HunteRoi commented Oct 1, 2022

@danny-may What about the builds failing?

@danny-may
Copy link
Contributor Author

Thats due to the yarn issue. Basically because dependencies are zipped files in .yarn/cache rather than normal folders in node_modules, yarn needs to inject in the logic to typescript to enable module lookups.
Without the fix from yarn, typescript cannot find any of the projects dependencies and so fails to build

@danny-may danny-may merged commit 88459c0 into master Oct 7, 2022
@danny-may danny-may deleted the chore/update-dependencies branch October 7, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants