Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS 4.8.4 not working #4915

Closed
1 task
simPod opened this issue Sep 27, 2022 · 11 comments · Fixed by #4903
Closed
1 task

TS 4.8.4 not working #4915

simPod opened this issue Sep 27, 2022 · 11 comments · Fixed by #4903
Assignees
Labels
bug Something isn't working upholded Real issues without formal reproduction

Comments

@simPod
Copy link

simPod commented Sep 27, 2022

Self-service

  • I'd be willing to implement a fix

Describe the bug

TS 4.8.3 works fine but 4.8.4 fails to find like any module (using pnp)

error TS2307: Cannot find module 'lodash' or its corresponding type declarations.

To reproduce

https://github.com/simPod/berry/actions/runs/3139391885/jobs/5099759100

Run test

Environment

See https://github.com/simPod/berry/actions/runs/3139391885/jobs/5099759100

Additional context

No response

@simPod simPod added the bug Something isn't working label Sep 27, 2022
@merceyz merceyz self-assigned this Sep 27, 2022
@merceyz merceyz added the upholded Real issues without formal reproduction label Sep 27, 2022
@merceyz merceyz pinned this issue Sep 28, 2022
@RDIL RDIL changed the title [Bug?]: TS 4.8.4 somehow fails to find modules TS 4.8.4 not working Oct 1, 2022
@stefpb
Copy link

stefpb commented Oct 4, 2022

Sorry, for me this problem still exists. What i have to do to retrieve the latest changes? I tried yarn set version latest but it doesnt change anything.

@koshic
Copy link

koshic commented Oct 4, 2022

@stefpb fix available only for 4.0.0-xx branches - see vuejs/language-tools#918 (comment)

@okinawaa

This comment was marked as spam.

@okinawaa
Copy link

okinawaa commented Oct 5, 2022

There is an error in the current version of typescript 4.8.4.
Lowering it to 4.8.3 will resolve it. From yarn-berry(yarn2)
I've looked for a lot of ways to lower the version of the typescript.
follow my process

yarn remove typescript
yarn add -D typescript@4.8.3
rm -rf .yarn/sdks/typescript
yarn dlx @yarnpkg/sdks base

don't forget your vscode look workspace's typescript version (mac : cmd + shift + p => typescript version use Workspace)

@stefpb

This comment was marked as duplicate.

@merceyz
Copy link
Member

merceyz commented Oct 5, 2022

The fix is now available in v3.2.4

yarn set version berry

@IgnusG
Copy link

IgnusG commented Nov 1, 2022

Hmm, for me it still doesn't seem to work on yarn v3.2.4. Downgrading to typescript 4.8.3 worked well though

@koshic
Copy link

koshic commented Nov 1, 2022

Hmm, for me it still doesn't seem to work on yarn v3.2.4. Downgrading to typescript 4.8.3 worked well though

Try to refresh yarn.lock too

@merceyz
Copy link
Member

merceyz commented Nov 1, 2022

Hmm, for me it still doesn't seem to work on yarn v3.2.4.

Did you run an install?

Try to refresh yarn.lock too

That shouldn't matter.

@IgnusG
Copy link

IgnusG commented Nov 1, 2022

Hmm, for me it still doesn't seem to work on yarn v3.2.4.

Did you run an install?

Try to refresh yarn.lock too

That shouldn't matter.

Yeah I did but it was still failing. After changing to typescript version 4.8.3 and installing and then back to 4.8.4 now and installing again it works though 🎉 (maybe something was caching incorrectly or I was running the commands in the wrong order)

@gmeligio
Copy link

Hmm, for me it still doesn't seem to work on yarn v3.2.4.

Did you run an install?

Try to refresh yarn.lock too

That shouldn't matter.

Yeah I did but it was still failing. After changing to typescript version 4.8.3 and installing and then back to 4.8.4 now and installing again it works though 🎉 (maybe something was caching incorrectly or I was running the commands in the wrong order)

It was failing for me in vscode with yarn v3.2.4 but the hint "running the commands in the wrong order" solved it. I got it working by reverting my changes and doing the updates in this order:

  1. yarn set version latest to get yarn v3.2.4
  2. yarn upgrade-interactive to get typescript v4.8.4
  3. yarn dlx @yarnpkg/sdks vscode to get the yarn sdks for vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upholded Real issues without formal reproduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants