Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HRRR-Zarr demo program #155

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Jan 15, 2023

Dear Brian,

while working on adding a HRRR-Zarr access use-case to GH-153, I took the chance to update the example stub you've provided.

  • load_dataset accounts for the projection details.
  • load_combined_dataset accounts for the directory layout regarding the extra level of nesting for the main data variable.

The gist is from 1, thanks a stack to the original author(s) 2.

With kind regards,
Andreas.

Footnotes

  1. https://mesowest.utah.edu/html/hrrr/zarr_documentation/html/xarray_one_day_analysis_example.html 2

  2. I have not been able to discover the author(s) of those resources, so I co-attributed it 1 to @taylorgowan. Is it correct, or has it actually been you, or maybe another co-author of one the papers that have been published in this space?

- `load_dataset` accounts for the projection details.
- `load_combined_dataset` accounts for the directory layout regarding
  the extra level of nesting for the main data variable.
@blaylockbk
Copy link
Owner

Good question.
@taylorgowan I'm 99% certain you authored the example notebook referenced. Is that correct? Are there other notebooks/authors that should be referenced?

@amotl I learned about xarray datatree at the AMS meeting last week. I understand it can read multi-nested zarr groups. Perhaps that can be used here?

@amotl
Copy link
Contributor Author

amotl commented Jan 15, 2023

I learned about xarray datatree at the AMS meeting last week. I understand it can read multi-nested zarr groups. Perhaps that can be used here?

Interesting. Thanks. My intention was to bring in a canonical example how to read HRRR-Zarr from the resources which are already there. I think it can be worth to evaluate if the same can be achieved with more modern libraries on another iteration, or by providing an alternative example.

Parts of this code will converge into GH-153 anyway, but I thought it would be a could idea to provide a standalone version on behalf of this patch, for others to pick up from the Herbie code base.

Because this is code which will probably be staged elsewhere within Herbie, I think this file will go away on a subsequent iteration.

@blaylockbk blaylockbk merged commit 9a6cafe into blaylockbk:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants