Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Herbie's model templates #287

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

blaylockbk
Copy link
Owner

@blaylockbk blaylockbk commented Mar 5, 2024

The goal of these changes to the model templates is to help improve maintainability in the model templates.

  • Do the input validation to the model template rather than in the Herbie class. This will be nice since models sometimes need unique conditions or arguments that are not needed for other models.
  • Control the Herbie arguments from the model template, and alert the user when wrong input is given.

General rules for Herbie model templates

  1. Each template will represent data from the same NWP model; data sources may be in different locations.
  2. The template will include three sections
    1. Metadata
    2. Validation
    3. Build Source URLs
  3. Somehow need to keep the template simple enough (and predictable) that others can help keep these updated when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant