allow blaze client to disable ssl verification #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isn't that what you've implemented here? |
|
or do you mean use |
yeah, this just makes it so that if it uses ssl with a custom cert that it doesn't check the cert. I imagine most production setups will want to serve their data with https. |
|
@llllllllll this can be merged after fixing up conflicts and passing |
llllllllll
added a commit
that referenced
this pull request
Jul 13, 2015
allow blaze client to disable ssl verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifies the cert by default; however, we want to disable this
Side note: we might want to think about making ssl the default. There is no downside really and it helps people who might not have thought about the fact that they will be streaming potentially sensitive data over the interned.
note: wait for #1172 and then change the .get to .post