Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: correct isidentical for interactive symbols backed with nans #1387

Merged

Conversation

llllllllll
Copy link
Member

Fixes an infinite recursion error that would occur when comparing equality equality against fields of a bound symbol where the resource was an ndarray or ndframe with nans

This goes back to the old behavior of not checking the arrays. This is really slow anyways.

I would really prefer to merge: #1348 over this pr

@llllllllll llllllllll force-pushed the isidentical-for-interactive-symbols branch 3 times, most recently from c785f07 to 2e3d4d5 Compare January 20, 2016 21:34
@llllllllll llllllllll changed the title BUG: correct isidentical for things with non hashable args BUG: correct isidentical for interactive symbols backed with nans Jan 22, 2016
@llllllllll llllllllll changed the title BUG: correct isidentical for interactive symbols backed with nans BUG: correct isidentical for interactive symbols backed with nans Jan 22, 2016
llllllllll added a commit that referenced this pull request Jan 22, 2016
…symbols

BUG: correct isidentical for interactive symbols backed with nans
@llllllllll llllllllll merged commit 831116a into blaze:master Jan 22, 2016
@llllllllll llllllllll deleted the isidentical-for-interactive-symbols branch January 22, 2016 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant